Bug 166854

Summary: 26 MotionMark performance tests failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, glenn, jonlee, rniwa, sabouhallawa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2017-01-09 11:13:34 PST
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Perf%29/builds/3976 Running MotionMark/developer.html (127 of 187) ERROR: layer at (0,0) size 785x1043 FAILED Finished: 0.731144 s Running MotionMark/index.html (128 of 187) ERROR: layer at (0,0) size 785x637 FAILED Finished: 0.634332 s Running MotionMark/tests/3d/webgl.html (129 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.586785 s Running MotionMark/tests/bouncing-particles/bouncing-canvas-images.html (130 of 187) ERROR: layer at (0,0) size 785x785 FAILED Finished: 0.595331 s Running MotionMark/tests/bouncing-particles/bouncing-canvas-shapes.html (131 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.590061 s Running MotionMark/tests/bouncing-particles/bouncing-css-images.html (132 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.580031 s Running MotionMark/tests/bouncing-particles/bouncing-css-shapes.html (133 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.578115 s Running MotionMark/tests/bouncing-particles/bouncing-svg-images.html (134 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.596807 s Running MotionMark/tests/bouncing-particles/bouncing-svg-shapes.html (135 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.591946 s Running MotionMark/tests/bouncing-particles/bouncing-tagged-images.html (136 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.578116 s Running MotionMark/tests/dom/compositing-transforms.html (137 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.583214 s Running MotionMark/tests/dom/focus.html (138 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.590144 s Running MotionMark/tests/dom/leaves.html (139 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.590049 s Running MotionMark/tests/dom/particles.html (140 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.581178 s Running MotionMark/tests/master/canvas-stage.html (141 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.594483 s Running MotionMark/tests/master/focus.html (142 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.577741 s Running MotionMark/tests/master/image-data.html (143 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.583173 s Running MotionMark/tests/master/leaves.html (144 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.582737 s Running MotionMark/tests/master/multiply.html (145 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.582689 s Running MotionMark/tests/master/svg-particles.html (146 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.591414 s Running MotionMark/tests/master/text.html (147 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.627289 s Running MotionMark/tests/simple/simple-canvas-paths.html (148 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.589198 s Running MotionMark/tests/simple/tiled-canvas-image.html (149 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.591449 s Running MotionMark/tests/template/template-canvas.html (150 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.593032 s Running MotionMark/tests/template/template-css.html (151 of 187) ERROR: layer at (0,0) size 800x600 FAILED Finished: 0.584448 s Running MotionMark/tests/template/template-svg.html (152 of 187) ERROR: layer at (0,0) size 785x603 FAILED Finished: 0.591388 s
Attachments
Patch (3.08 KB, patch)
2017-01-13 17:08 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2017-01-09 11:53:01 PST
It seems all the MotionMark tests did not run. How do these tests run on the webkit bots? Do we use Tools/Scripts/run-benchmark to run them?
Ryan Haddad
Comment 2 2017-01-09 12:41:03 PST
(In reply to comment #1) > It seems all the MotionMark tests did not run. How do these tests run on the > webkit bots? Do we use Tools/Scripts/run-benchmark to run them? In this case they seem to be running with Tools/Scripts/run-perf-tests
Said Abou-Hallawa
Comment 3 2017-01-13 17:03:53 PST
I just realized that Animometer had never run on the WebKit bots. It was skipped in the file PerformanceTests/Skipped. When the name was changed to MotionMark, it runs by default which we don't want. The fix is to skip MotionMark instead of Animometer in PerformanceTests/Skipped.
Said Abou-Hallawa
Comment 4 2017-01-13 17:08:48 PST
Created attachment 298811 [details] Patch
WebKit Commit Bot
Comment 5 2017-01-13 19:19:00 PST
Comment on attachment 298811 [details] Patch Clearing flags on attachment: 298811 Committed r210757: <http://trac.webkit.org/changeset/210757>
WebKit Commit Bot
Comment 6 2017-01-13 19:19:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.