Summary: | [Win] The test fast/forms/validation-message-maxLength.html is failing. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | WebCore Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | achristensen, ap, bfulgham, cdumez, darin | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Per Arne Vollan
2017-01-09 06:34:25 PST
Created attachment 298351 [details]
Patch
Why is it only failing on windows? Where is the "one" coming from right now? It seems like we shouldn't make a special case for 1 I don't think that his change is right. 1. Special casing 1 is only correct for some languages; other languages have different rules for plurals. ICU has support for this, although we haven't used it in WebKit directly yet: <http://userguide.icu-project.org/formatparse/messages>. 2. Chris told me that form validation is not enabled on Windows anyway. Comment on attachment 298351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298351&action=review > Source/WebCore/platform/LocalizedStrings.cpp:1153 > + if (maxLength == 1) This is exactly what we tried to avoid on Mac: see https://bugs.webkit.org/show_bug.cgi?id=166712. (In reply to comment #3) > I don't think that his change is right. > > 1. Special casing 1 is only correct for some languages; other languages have > different rules for plurals. > > ICU has support for this, although we haven't used it in WebKit directly > yet: <http://userguide.icu-project.org/formatparse/messages>. > > 2. Chris told me that form validation is not enabled on Windows anyway. The form validation *UI* is not supported on Windows. However, you can still access the localized validation strings on Windows via input.validationMessage in JS, as demonstrated in the test. (In reply to comment #5) > (In reply to comment #3) > > I don't think that his change is right. > > > > 1. Special casing 1 is only correct for some languages; other languages have > > different rules for plurals. > > > > ICU has support for this, although we haven't used it in WebKit directly > > yet: <http://userguide.icu-project.org/formatparse/messages>. > > > > 2. Chris told me that form validation is not enabled on Windows anyway. > > The form validation *UI* is not supported on Windows. However, you can still > access the localized validation strings on Windows via > input.validationMessage in JS, as demonstrated in the test. Ok, thanks for reviewing, guys :) I'll update the test expectations instead. Longer term, we should probably look into having/using stringsdict on Windows too. |