Bug 16683

Summary: speed up function calls by making ScopeChain::push cheaper
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED WONTFIX    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch
darin: review-
newer patch, but doesn't seem to be a speedup none

Description Darin Adler 2007-12-31 00:56:03 PST 
Function calls push an activation object on the scope chain. We can make this cheaper by cutting down on heap allocation.
Comment 1 Darin Adler 2007-12-31 01:07:03 PST 
Created attachment 18211 [details]
patch
Comment 2 Geoffrey Garen 2008-01-01 10:39:40 PST 
Comment on attachment 18211 [details]
patch

r=me
Comment 3 Darin Adler 2008-01-01 11:14:00 PST 
Committed revision 29065.
Comment 4 Darin Adler 2008-01-01 11:46:00 PST 
This broke the world. Rolling it back out.
Comment 5 Darin Adler 2008-01-01 23:06:39 PST 
There's too much overlap between this and the coming Activation optimization. I'm going to drop it.
Comment 6 Darin Adler 2008-01-02 16:34:19 PST 
Created attachment 18244 [details]
newer patch, but doesn't seem to be a speedup
Comment 7 Darin Adler 2008-01-02 16:35:02 PST 
Comment on attachment 18244 [details]
newer patch, but doesn't seem to be a speedup

Hmm, no, that was just aother copy of the wrong patch.