Bug 16683

Summary: speed up function calls by making ScopeChain::push cheaper
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED WONTFIX    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch
darin: review-
newer patch, but doesn't seem to be a speedup none

Darin Adler
Reported 2007-12-31 00:56:03 PST
Function calls push an activation object on the scope chain. We can make this cheaper by cutting down on heap allocation.
Attachments
patch (7.57 KB, patch)
2007-12-31 01:07 PST, Darin Adler 		darin: review-
DetailsFormatted DiffDiff
newer patch, but doesn't seem to be a speedup (7.57 KB, patch)
2008-01-02 16:34 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2007-12-31 01:07:03 PST
Created attachment 18211 [details] patch
Geoffrey Garen
Comment 2 2008-01-01 10:39:40 PST
Comment on attachment 18211 [details] patch r=me
Darin Adler
Comment 3 2008-01-01 11:14:00 PST
Committed revision 29065.
Darin Adler
Comment 4 2008-01-01 11:46:00 PST
This broke the world. Rolling it back out.
Darin Adler
Comment 5 2008-01-01 23:06:39 PST
There's too much overlap between this and the coming Activation optimization. I'm going to drop it.
Darin Adler
Comment 6 2008-01-02 16:34:19 PST
Created attachment 18244 [details] newer patch, but doesn't seem to be a speedup
Darin Adler
Comment 7 2008-01-02 16:35:02 PST
Comment on attachment 18244 [details] newer patch, but doesn't seem to be a speedup Hmm, no, that was just aother copy of the wrong patch.
Note You need to log in before you can comment on or make changes to this bug.