Bug 16674

Summary: [GTK] run-launcher sets wrong LD_LIBRARY_PATH
Product: WebKit Reporter: Luca Bruno <lethalman88>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Severity: Trivial CC: lethalman88
Priority: P3 Keywords: EasyFix, Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Description Flags
use /lib
use catdir darin: review+

Description Luca Bruno 2007-12-30 02:23:25 PST
Hello, the run-launcher uses WebKitBuild/{build} as LD_LIBRARY_PATH instead of WebKitBuild/{build}/lib.
Maybe this issue is only for GtkLauncher and other ports don't need /lib?
Comment 1 Luca Bruno 2007-12-30 02:27:25 PST
Created attachment 18185 [details]
use /lib

Very simple patch.
Comment 2 David Kilzer (:ddkilzer) 2007-12-30 08:28:53 PST
This needs to be reviewed by a Qt developer to make sure this doesn't break launching QtLauncher.

It may also be wise to start using the catdir() function from the File::Spec Perl module to concatenate paths.

Comment 3 Luca Bruno 2007-12-30 11:30:08 PST
Created attachment 18195 [details]
use catdir

I'm not able to run Qt if LD_LIBRARY_PATH is not set to /lib currently, but i don't use Qt at all.
Comment 4 Darin Adler 2008-01-01 01:18:08 PST
Comment on attachment 18195 [details]
use catdir

Even though I'm no expert on the details here, this looks fine to me. r=me
Comment 5 Alp Toker 2008-01-02 04:56:52 PST
Landed in r29081.