Bug 166725

Summary: prepare-ChangeLog: Correct help string for --style option
Product: WebKit Reporter: Milan Crha <mcrha>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, lforschler, tpopela
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
ap: review-, ap: commit-queue-
proposed patch ][ none

Description Milan Crha 2017-01-05 05:44:30 PST 
Running:
   $ ./Tools/Scripts/prepare-ChangeLog --help
claims:

   --[no-]style    Run check-webkit-style script when done (default: style)

but this is not true, because if I do not use the --style argument, then the coding style is not checked.
Comment 1 Milan Crha 2017-01-05 05:47:02 PST 
Created attachment 298096 [details]
proposed patch

The variable was not initialized, which this one-liner does.
Comment 2 Alexey Proskuryakov 2017-01-05 12:41:26 PST 
Comment on attachment 298096 [details]
proposed patch

This is intentional behavior, implemented in bug 132209.
Comment 3 Alexey Proskuryakov 2017-01-05 12:42:50 PST 
The help text is wrong though, good catch!
Comment 4 Milan Crha 2017-01-06 00:31:56 PST 
Right, in that case the help text should be fixed. Thanks.
Comment 5 Milan Crha 2017-01-09 08:24:40 PST 
Created attachment 298359 [details]
proposed patch ][
Comment 6 Alexey Proskuryakov 2017-01-09 09:17:30 PST 
Comment on attachment 298359 [details]
proposed patch ][

r=me

Thank you!
Comment 7 WebKit Commit Bot 2017-01-09 09:42:27 PST 
Comment on attachment 298359 [details]
proposed patch ][

Clearing flags on attachment: 298359

Committed r210512: <http://trac.webkit.org/changeset/210512>
Comment 8 WebKit Commit Bot 2017-01-09 09:42:31 PST 
All reviewed patches have been landed.  Closing bug.