Bug 166725

Summary: prepare-ChangeLog: Correct help string for --style option
Product: WebKit Reporter: Milan Crha <mcrha>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, lforschler, tpopela
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
ap: review-, ap: commit-queue-
proposed patch ][ none

Milan Crha
Reported 2017-01-05 05:44:30 PST
Running: $ ./Tools/Scripts/prepare-ChangeLog --help claims: --[no-]style Run check-webkit-style script when done (default: style) but this is not true, because if I do not use the --style argument, then the coding style is not checked.
Attachments
proposed patch (955 bytes, patch)
2017-01-05 05:47 PST, Milan Crha 		ap: review-
ap: commit-queue-
DetailsFormatted DiffDiff
proposed patch ][ (1.82 KB, patch)
2017-01-09 08:24 PST, Milan Crha 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Milan Crha
Comment 1 2017-01-05 05:47:02 PST
Created attachment 298096 [details] proposed patch The variable was not initialized, which this one-liner does.
Alexey Proskuryakov
Comment 2 2017-01-05 12:41:26 PST
Comment on attachment 298096 [details] proposed patch This is intentional behavior, implemented in bug 132209.
Alexey Proskuryakov
Comment 3 2017-01-05 12:42:50 PST
The help text is wrong though, good catch!
Milan Crha
Comment 4 2017-01-06 00:31:56 PST
Right, in that case the help text should be fixed. Thanks.
Milan Crha
Comment 5 2017-01-09 08:24:40 PST
Created attachment 298359 [details] proposed patch ][
Alexey Proskuryakov
Comment 6 2017-01-09 09:17:30 PST
Comment on attachment 298359 [details] proposed patch ][ r=me Thank you!
WebKit Commit Bot
Comment 7 2017-01-09 09:42:27 PST
Comment on attachment 298359 [details] proposed patch ][ Clearing flags on attachment: 298359 Committed r210512: <http://trac.webkit.org/changeset/210512>
WebKit Commit Bot
Comment 8 2017-01-09 09:42:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.