Bug 166721

Summary:

Use WTF::Function instead of std::function in network cache code

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, cdumez, cgarcia, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	kling: review+, buildbot: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
patch	none
patch	none
patch	none

Antti Koivisto

Reported 2017-01-05 02:51:53 PST

Use better move-only type

Attachments
patch (11.93 KB, patch) 2017-01-05 03:00 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (11.93 KB, patch) 2017-01-05 03:13 PST, Antti Koivisto	kling: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (deleted) 2017-01-05 04:08 PST, Build Bot	no flags	Details
patch (16.63 KB, patch) 2017-01-05 06:05 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (16.53 KB, patch) 2017-01-05 07:36 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (17.37 KB, patch) 2017-01-05 09:59 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-01-05 03:00:28 PST

Created attachment 298084 [details] patch

WebKit Commit Bot

Comment 2 2017-01-05 03:02:34 PST

Attachment 298084 [details] did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:891: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:312: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:589: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.h:38: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataSoup.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:122: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 12 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 3 2017-01-05 03:13:03 PST

Created attachment 298086 [details] patch

WebKit Commit Bot

Comment 4 2017-01-05 03:14:29 PST

Attachment 298086 [details] did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:891: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:312: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:589: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.h:38: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataSoup.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:122: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 12 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2017-01-05 04:08:35 PST

Comment on attachment 298086 [details] patch Attachment 298086 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2837488 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2017-01-05 04:08:47 PST

Created attachment 298090 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 7 2017-01-05 06:05:39 PST

Created attachment 298097 [details] patch

WebKit Commit Bot

Comment 8 2017-01-05 06:08:28 PST

Attachment 298097 [details] did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:312: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:591: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.h:38: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:891: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataSoup.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:122: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 12 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 9 2017-01-05 07:36:40 PST

Created attachment 298102 [details] patch

WebKit Commit Bot

Comment 10 2017-01-05 07:53:10 PST

Attachment 298102 [details] did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:312: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:591: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.h:38: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:891: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataSoup.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:122: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 12 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 11 2017-01-05 09:59:52 PST

Created attachment 298110 [details] patch

WebKit Commit Bot

Comment 12 2017-01-05 10:01:48 PST

Attachment 298110 [details] did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:131: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:312: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:591: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.h:38: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:891: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheDataSoup.cpp:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:122: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 12 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 13 2017-01-05 11:14:45 PST

https://trac.webkit.org/r210364

Brady Eidson

Comment 14 2017-01-05 12:11:03 PST

👍👍👍

Note You need to log in before you can comment on or make changes to this bug.