Bug 166671

Summary: Remove final custom binding from IDBRequest
Product: WebKit Reporter: Sam Weinig <sam>
Component: BindingsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch achristensen: review+

Sam Weinig
Reported 2017-01-03 17:01:02 PST
Remove final custom binding from IDBRequest
Attachments
Patch (26.65 KB, patch)
2017-01-03 17:05 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (26.83 KB, patch)
2017-01-03 17:15 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (26.64 KB, patch)
2017-01-03 17:16 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (26.67 KB, patch)
2017-01-03 17:29 PST, Sam Weinig 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-01-03 17:05:09 PST
Created attachment 297970 [details] Patch
Sam Weinig
Comment 2 2017-01-03 17:15:37 PST
Created attachment 297972 [details] Patch
Sam Weinig
Comment 3 2017-01-03 17:16:32 PST
Created attachment 297973 [details] Patch
Sam Weinig
Comment 4 2017-01-03 17:29:52 PST
Created attachment 297977 [details] Patch
Alex Christensen
Comment 5 2017-01-03 22:57:49 PST
Comment on attachment 297977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297977&action=review r=me > Source/WebCore/Modules/indexeddb/IDBRequest.cpp:149 > + [] (RefPtr<IDBCursor>& cursor) { cursor->clearRequest(); }, You have several uses of Variant<RefPtr<Something>, etc.> that use the RefPtr without checking if it's null in this patch. Could they become Variant<Ref<Something>, etc.>?
Darin Adler
Comment 6 2017-01-03 23:59:57 PST
Comment on attachment 297977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297977&action=review >> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:149 >> + [] (RefPtr<IDBCursor>& cursor) { cursor->clearRequest(); }, > > You have several uses of Variant<RefPtr<Something>, etc.> that use the RefPtr without checking if it's null in this patch. Could they become Variant<Ref<Something>, etc.>? Currently they can’t, but this is something Sam would like to fix eventually. Sam, why RefPtr& here rather than const RefPtr&? > Source/WebCore/Modules/indexeddb/IDBRequest.cpp:454 > + [] (RefPtr<IDBCursor>& cursor) -> IDBCursor* { return cursor.get(); }, Why not const RefPtr&?
Sam Weinig
Comment 7 2017-01-04 09:49:54 PST
Committed r210275: <http://trac.webkit.org/changeset/210275>
Note You need to log in before you can comment on or make changes to this bug.