Bug 166656

Summary:

Update pointer-lock test expectations, enabling passing tests.

Product:

WebKit

Reporter:

Jeremy Jones <jeremyj-wk>

Component:

New Bugs

Assignee:

Jeremy Jones <jeremyj-wk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=166765

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Jeremy Jones

Reported 2017-01-03 11:27:29 PST

Update pointer-lock test expectations, enabling passing tests.

Attachments
Patch (2.05 KB, patch) 2017-01-03 11:34 PST, Jeremy Jones	no flags	Details Formatted Diff Diff
Patch (2.44 KB, patch) 2017-01-03 12:05 PST, Jeremy Jones	no flags	Details Formatted Diff Diff
Patch (2.44 KB, patch) 2017-01-03 12:11 PST, Jeremy Jones	no flags	Details Formatted Diff Diff
Patch (4.49 KB, patch) 2017-01-03 15:05 PST, Jeremy Jones	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jeremy Jones

Comment 1 2017-01-03 11:29:40 PST

rdar://problem/29851126

Jeremy Jones

Comment 2 2017-01-03 11:34:12 PST

Created attachment 297937 [details] Patch

Jeremy Jones

Comment 3 2017-01-03 12:05:42 PST

Created attachment 297939 [details] Patch

Jeremy Jones

Comment 4 2017-01-03 12:11:22 PST

Created attachment 297941 [details] Patch

Jeremy Jones

Comment 5 2017-01-03 15:05:19 PST

Created attachment 297958 [details] Patch

WebKit Commit Bot

Comment 6 2017-01-05 12:38:05 PST

Comment on attachment 297958 [details] Patch Clearing flags on attachment: 297958 Committed r210371: <http://trac.webkit.org/changeset/210371>

WebKit Commit Bot

Comment 7 2017-01-05 12:38:09 PST

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 8 2017-01-05 15:38:11 PST

Some of these tests are failing assertions: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r210375%20(10236)/results.html ASSERTION FAILED: !m_isPointerLocked /Volumes/Data/slave/elcapitan-debug/build/Source/WebKit2/UIProcess/WebPageProxy.cpp(6763) : void WebKit::WebPageProxy::requestPointerLock() 1 0x10a3b0dd0 WTFCrash 2 0x10d4dc368 WebKit::WebPageProxy::requestPointerLock() 3 0x10d572a23 void IPC::callMemberFunctionImpl<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(), std::__1::tuple<> >(WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(), std::__1::tuple<>&&, std::__1::integer_sequence<unsigned long>) 4 0x10d572998 void IPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(), std::__1::tuple<>, std::__1::integer_sequence<unsigned long> >(std::__1::tuple<>&&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)()) 5 0x10d56cbe9 void IPC::handleMessage<Messages::WebPageProxy::RequestPointerLock, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)()>(IPC::Decoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)()) 6 0x10d55e394 WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 7 0x10d55e8b7 non-virtual thunk to WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 8 0x10ce7cd14 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 9 0x10cd4e7d7 WebKit::ChildProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 10 0x10d66c03a WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 11 0x10d66c137 non-virtual thunk to WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 12 0x10cd5d6f3 IPC::Connection::dispatchMessage(IPC::Decoder&) 13 0x10cd549d1 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 14 0x10cd544be IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*) 15 0x10cd5d019 IPC::Connection::dispatchSyncMessage(IPC::Decoder&) 16 0x10cd54992 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 17 0x10cd544be IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*) 18 0x10cd5948c IPC::Connection::waitForSyncReply(unsigned long long, WTF::Seconds, WTF::OptionSet<IPC::SendSyncOption>) 19 0x10cd57bbb IPC::Connection::sendSyncMessage(unsigned long long, std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >, WTF::Seconds, WTF::OptionSet<IPC::SendSyncOption>) 20 0x10cd570bc IPC::Connection::sendMessage(std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >, WTF::OptionSet<IPC::SendOption>) 21 0x10cd4e4d0 WebKit::ChildProcessProxy::sendMessage(std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >, WTF::OptionSet<IPC::SendOption>) 22 0x10d4f59c2 bool WebKit::ChildProcessProxy::send<Messages::WebPage::KeyEvent>(Messages::WebPage::KeyEvent&&, unsigned long long, WTF::OptionSet<IPC::SendOption>) 23 0x10d4c2ce1 WebKit::WebPageProxy::handleKeyboardEvent(WebKit::NativeWebKeyboardEvent const&) 24 0x10d743909 invocation function for block in WebKit::WebViewImpl::keyDown(NSEvent*) 25 0x10d740d44 WebKit::WebViewImpl::interpretKeyEvent(NSEvent*, void (signed char, WTF::Vector<WebCore::KeypressCommand, 0ul, WTF::CrashOnOverflow, 16ul> const&) block_pointer) 26 0x10d743813 WebKit::WebViewImpl::keyDown(NSEvent*) 27 0x10d83c346 -[WKWebView keyDown:] 28 0x108e27d97 WTR::EventSenderProxy::keyDown(OpaqueWKString const*, unsigned int, unsigned int) 29 0x108e49ac6 WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle(OpaqueWKDictionary const*, bool) 30 0x108e48fa7 WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*) 31 0x108e3fe9f WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle(OpaqueWKPage const*, OpaqueWKString const*, void const*, void const**, void const*)

Note You need to log in before you can comment on or make changes to this bug.