Bug 166570

Summary: Web Inspector: opening Test.html in a normal browser window doesn't log errors to console
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Blaze Burg
Reported 2016-12-28 22:19:55 PST
The check we used was not correct.
Attachments
Patch (2.46 KB, patch)
2016-12-28 22:24 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2016-12-28 22:24:18 PST
Created attachment 297821 [details] Patch
Joseph Pecoraro
Comment 2 2017-01-03 13:37:21 PST
Comment on attachment 297821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297821&action=review r=me, nice! I've hit this a few times in the past, this will be very useful. > Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:-198 > - if (this._originalConsole && (!InspectorFrontendHost || !InspectorBackend)) { Errr these checks would never have done anything anyways, they would have ReferenceErrored! Who reviewed that? =)
WebKit Commit Bot
Comment 3 2017-01-03 14:13:23 PST
Comment on attachment 297821 [details] Patch Clearing flags on attachment: 297821 Committed r210249: <http://trac.webkit.org/changeset/210249>
WebKit Commit Bot
Comment 4 2017-01-03 14:13:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.