Summary: | Acid3 failure since table.caption and table.thead do not work for nodes added by appendChild | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | DOM | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, bdakin, darin, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2007-12-28 22:09:58 PST
It looks like the addChild logic is never called for appendChild, thus the HTMLTableElement doesn't know to fix up its m_caption pointer. I've got a fix for this. Created attachment 18233 [details] patch (fixes this and bug 16659 too) Comment on attachment 18233 [details] patch (fixes this and bug 16659 too) I think this patch looks great. I wondered what our testing coverage is for multiple <tfoot> <thead> elements is, since those look like edge cases we need to support (and looks like we try to currently). I'd r+ this, except that I don't 100% trust my review given my fatigue and lack of table knowledge. A second pair of eyes is recommended before landing. Comment on attachment 18233 [details] patch (fixes this and bug 16659 too) r=me |