Bug 166476

Summary: [JSC] Implement (Shared)ArrayBuffer.prototype.byteLength
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfbastien, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Description Yusuke Suzuki 2016-12-25 09:39:22 PST 
...
Comment 2 Yusuke Suzuki 2016-12-25 10:00:36 PST 
We already have SharedArrayBuffer. So when implementing ArrayBuffer.prototype.byteLength, we should refer to the updated one in SharedArrayBuffer spec.
Comment 4 Radar WebKit Bug Importer 2017-01-30 15:01:37 PST 
<rdar://problem/30273638>
Comment 5 JF Bastien 2017-01-30 15:01:56 PST 
This seems to be the one reason we're not at 100% in this:
 http://kangax.github.io/compat-table/es2016plus/

Probably worth doing, it's simple.
Comment 6 Yusuke Suzuki 2017-02-09 07:16:28 PST 
Start working on this.
Comment 7 Yusuke Suzuki 2017-02-09 13:51:19 PST 
Created attachment 301078 [details]
Patch
Comment 8 Saam Barati 2017-02-10 19:33:12 PST 
Comment on attachment 301078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301078&action=review

r=me

> JSTests/stress/array-buffer-byte-length.js:27
> +    shouldBe(arrayBuffer.byteLength, 42);
> +    shouldBe(sharedArrayBuffer.byteLength, 500);

Can you also add a test where HasOwnProperty(buffer, "byteLength") is false?

> JSTests/stress/array-buffer-byte-length.js:45
> +    shouldThrow(() => {
> +        Object.getOwnPropertyDescriptor(ArrayBuffer.prototype, 'byteLength').get.call(sharedArrayBuffer);
> +    }, `TypeError: Receiver should not be a shared array buffer`);
> +
> +    shouldThrow(() => {
> +        Object.getOwnPropertyDescriptor(SharedArrayBuffer.prototype, 'byteLength').get.call(arrayBuffer);
> +    }, `TypeError: Receiver should be a shared array buffer`);

Can you also add tests for the other assertions:
- !thisValue.isObject()
- !thisValue.arrayBuffer()
Comment 9 Yusuke Suzuki 2017-02-11 14:12:14 PST 
Comment on attachment 301078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301078&action=review

Thanks!

>> JSTests/stress/array-buffer-byte-length.js:27
>> +    shouldBe(sharedArrayBuffer.byteLength, 500);
> 
> Can you also add a test where HasOwnProperty(buffer, "byteLength") is false?

Added.

>> JSTests/stress/array-buffer-byte-length.js:45
>> +    }, `TypeError: Receiver should be a shared array buffer`);
> 
> Can you also add tests for the other assertions:
> - !thisValue.isObject()
> - !thisValue.arrayBuffer()

Added.
Comment 10 Yusuke Suzuki 2017-02-11 14:14:18 PST 
Committed r212196: <http://trac.webkit.org/changeset/212196>