Bug 166455

Summary: [GTK] GLES build broken since r208997
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, commit-queue, dino, graouts, kondapallykalyan, magomez, mcatanzaro, noam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2016-12-22 18:40:51 PST
GLES build is broken since r208997 (bug #164049). I don't normally ask for reviews for simple build failures, but I'm not sure about the right preprocessor guards to use here. Extensions3DOpenGLCommon::initializeAvailableExtensions currently guards its use of API not available in GLES2 with #if PLATFORM(MAC) || PLATFORM(GTK), which isn't good enough. At first I thought to change it to #if PLATFORM(MAC) || (PLATFORM(GTK) && !USE(OPENGL_ES_2)), but actually this code does not appear to be platform-specific, so maybe we can just use #if !USE(OPENGL_ES_2) here? Let's try that.
Attachments
Patch (1.66 KB, patch)
2016-12-22 18:43 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-12-22 18:43:05 PST
Created attachment 297699 [details] Patch
Miguel Gomez
Comment 2 2016-12-23 00:31:37 PST
I would use #if PLATFORM(MAC) || (PLATFORM(GTK) && !USE(OPENGL_ES_2)), which is what is intended to do: use this branch only if GLES2 is not enabled in WKGtk. There are also EFL and Win using this and they are probably going to break if the platform guards are removed.
Michael Catanzaro
Comment 3 2016-12-23 06:34:34 PST
Comment on attachment 297699 [details] Patch OK then
Michael Catanzaro
Comment 4 2016-12-23 06:37:36 PST
Committed r210133: <http://trac.webkit.org/changeset/210133>
Note You need to log in before you can comment on or make changes to this bug.