Bug 166437

Summary: WebAssembly: Make calling Wasm functions that returns or takes an i64 as a parameter an early exception
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, oliver, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch keith_miller: review+

Saam Barati
Reported 2016-12-22 14:51:20 PST
...
Attachments
patch (9.08 KB, patch)
2016-12-22 15:38 PST, Saam Barati 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-12-22 15:23:48 PST
<rdar://problem/29793949>
Saam Barati
Comment 2 2016-12-22 15:38:09 PST
Created attachment 297684 [details] patch
JF Bastien
Comment 3 2016-12-22 15:49:20 PST
Comment on attachment 297684 [details] patch lgtm
Keith Miller
Comment 4 2016-12-22 17:06:37 PST
Comment on attachment 297684 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=297684&action=review r=me with some comments. I think there is also an issue if the return value from wasm is an impure nan. It would be great if you could fix that when you land. I think it just needs a purifyNan call. > Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:69 > + "WebAssembly function with an int64 argument can't be called from JavaScript"); nit "with an i64 argument" > Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:76 > + "WebAssembly function that returns int64 can't be called from JavaScript"); nit "returns an i64" > Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:84 > JSValue arg = exec->uncheckedArgument(argIndex); This should be exec->argument(argIndex);
Saam Barati
Comment 5 2016-12-22 17:14:42 PST
Comment on attachment 297684 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=297684&action=review >> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:69 >> + "WebAssembly function with an int64 argument can't be called from JavaScript"); > > nit "with an i64 argument" SGTM >> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:76 >> + "WebAssembly function that returns int64 can't be called from JavaScript"); > > nit "returns an i64" SGTM >> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:84 >> JSValue arg = exec->uncheckedArgument(argIndex); > > This should be exec->argument(argIndex); We actually check argumentCount above so this isn't needed.
Saam Barati
Comment 6 2016-12-22 17:37:14 PST
landed in: https://trac.webkit.org/changeset/210126
Note You need to log in before you can comment on or make changes to this bug.