Bug 166403

Summary:

Make http/tests/security/popup-blocked-from-{fake-event, window-open}.html actually test popup blocker; run on WebKit2

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=166402

Attachments:

Description	Flags
Layout tests	darin: review+

Daniel Bates

Reported 2016-12-21 17:26:13 PST

The tests LayoutTests/http/tests/security/popup-blocked-from-{fake-event, window-open}.html inadvertently depend on the implementation implications of testRunner.setCanOpenWindows(), which is not implemented in WebKitTestRunner (see bug #166402), instead of testing that popup blocker logic.

Attachments
Layout tests (3.92 KB, patch) 2016-12-21 17:27 PST, Daniel Bates	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2016-12-21 17:27:23 PST

Created attachment 297641 [details] Layout tests

Daniel Bates

Comment 2 2016-12-22 14:27:25 PST

Committed r210113: <http://trac.webkit.org/changeset/210113>

Note You need to log in before you can comment on or make changes to this bug.