Bug 16614

Summary: REGRESSION(r26359-26570): Points in SVG kNN correlation model do not appear in ToT
Product: WebKit Reporter: Matt Lilek <dev+webkit>
Component: SVGAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue, eric, gsherloc, rwlbuis
Priority: P1 Keywords: HasReduction, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.cip.ifi.lmu.de/~schubert/kovar/
Attachments:
Description Flags
reduction
none
drt-compatible test case
none
Patch eric: review+, eric: commit-queue+

Matt Lilek
Reported 2007-12-26 14:23:34 PST
The points in the model at http://www.cip.ifi.lmu.de/~schubert/kovar/ do not appear in ToT (r28986). The site works fine in Safari 3.0.4.
Attachments
reduction (106 bytes, image/svg+xml)
2007-12-26 16:15 PST, Eric Seidel (no email) 		no flags
Details
drt-compatible test case (180 bytes, image/svg+xml)
2007-12-26 16:18 PST, Eric Seidel (no email) 		no flags
Details
Patch (17.45 KB, patch)
2011-05-15 14:59 PDT, Rob Buis 		eric: review+
eric: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-12-26 16:00:38 PST
This seems to be the reduction: <svg xmlns="http://www.w3.org/2000/svg"> <circle transform="scale(1000)" r="0.1" opacity=".99"/> </svg> (thanks Sam!)
Eric Seidel (no email)
Comment 2 2007-12-26 16:15:33 PST
Created attachment 18120 [details] reduction
Eric Seidel (no email)
Comment 3 2007-12-26 16:18:14 PST
Created attachment 18121 [details] drt-compatible test case
Eric Seidel (no email)
Comment 4 2007-12-26 16:36:35 PST
bisect-builds says: Works: r26359 Fails: r26570
Eric Seidel (no email)
Comment 5 2007-12-26 21:03:41 PST
My suspicion is that some calculation changed to use ints instead of floats which should not have.
Gavin Sherlock
Comment 6 2009-09-19 01:44:53 PDT
Is the result of the test supposed to be a green square? If so, this looks like it works correctly, both in Safari 4.03, and the latest nightly (r48518). The original bug url also seems to work, in that the points in the model do appear. I'm not able to determine when this progressed, as the oldest nightly build that I can test on 10.6 seems to work. Would be nice if there were a test case added (if there isn't already), but I think this can be closed.
Rob Buis
Comment 7 2011-05-15 14:59:50 PDT
Created attachment 93591 [details] Patch
Rob Buis
Comment 8 2011-05-15 15:00:40 PDT
(In reply to comment #7) > Created an attachment (id=93591) [details] > Patch See the ChangeLog, the bug is fixed but I think it may be a good idea to keep Eric's reduction test around. Cheers, Rob.
Eric Seidel (no email)
Comment 9 2011-05-15 16:03:43 PDT
Comment on attachment 93591 [details] Patch OK.
Rob Buis
Comment 10 2011-05-15 16:21:11 PDT
Committed r86514: <http://trac.webkit.org/changeset/86514>
Alexey Proskuryakov
Comment 11 2011-05-15 21:02:13 PDT
Is the expected result really platform specific? It's just a green square.
Ademar Reis
Comment 12 2011-05-17 09:55:59 PDT
FYI, this problem affects QtWebKit with current trunk. Not sure if it has the same root cause, but the "symptoms" are the same. Opened bug 60968 to track it.
Note You need to log in before you can comment on or make changes to this bug.