Bug 166067

Summary: check-webkit-style misinterprets 'const' in declarations
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=165975

Description Brent Fulgham 2016-12-20 09:11:29 PST
The 'check-webkit-style' script misinterprets the following method declaration;

    void setOverlayMessage(ErrorString&, const String* const) final;

It improperly believes that the second 'const' is a parameter name because it does not recognize that this is telling the compiler that the pointer cannot be changed:

    const String* immutableContents; // Declares a pointer whose contents cannot be changed.
    String* const immutablePointer; // Declares a pointer that cannot be changed.
    const String* const immutableContents; // Declares a pointer that cannot be changed, and whose contents cannot be changed.