Bug 166007

Summary:

Changing text direction fires input events with null inputTypes and no data

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, enrica, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Patch	sam: review+
Patch for landing	none

Wenson Hsieh

Reported 2016-12-17 22:54:03 PST

1. Go to whsieh.github.io/examples/input-events 2. Right click on either the top or bottom editable elements and change the paragraph direction. Observed: input events dispatched with null inputType

Attachments
Patch (15.91 KB, patch) 2016-12-18 00:44 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.09 MB, application/zip) 2016-12-18 01:45 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (deleted) 2016-12-18 01:48 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.10 MB, application/zip) 2016-12-18 01:49 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (1.69 MB, application/zip) 2016-12-18 01:51 PST, Build Bot	no flags	Details
Patch (13.61 KB, patch) 2016-12-18 10:04 PST, Wenson Hsieh	sam: review+	Details Formatted Diff Diff
Patch for landing (13.59 KB, patch) 2016-12-18 16:38 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2016-12-18 00:44:16 PST

Created attachment 297427 [details] Patch

Wenson Hsieh

Comment 2 2016-12-18 00:45:21 PST

<rdar://problem/29557205>

Build Bot

Comment 3 2016-12-18 01:45:01 PST

Comment on attachment 297427 [details] Patch Attachment 297427 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2747858 New failing tests: editing/style/change-text-direction-crash.html editing/execCommand/enabling-and-selection-2.html editing/style/make-text-writing-direction-inline-mac.html editing/style/make-text-writing-direction-inline-win.html

Build Bot

Comment 4 2016-12-18 01:45:04 PST

Created attachment 297429 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-12-18 01:48:12 PST

Comment on attachment 297427 [details] Patch Attachment 297427 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2747820 New failing tests: editing/style/change-text-direction-crash.html editing/execCommand/enabling-and-selection-2.html editing/style/make-text-writing-direction-inline-win.html

Build Bot

Comment 6 2016-12-18 01:48:15 PST

Created attachment 297430 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2016-12-18 01:49:14 PST

Comment on attachment 297427 [details] Patch Attachment 297427 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2747865 New failing tests: editing/style/change-text-direction-crash.html editing/execCommand/enabling-and-selection-2.html editing/style/make-text-writing-direction-inline-mac.html editing/style/make-text-writing-direction-inline-win.html

Build Bot

Comment 8 2016-12-18 01:49:17 PST

Created attachment 297431 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-12-18 01:51:56 PST

Comment on attachment 297427 [details] Patch Attachment 297427 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2747860 New failing tests: editing/style/change-text-direction-crash.html editing/execCommand/enabling-and-selection-2.html editing/style/make-text-writing-direction-inline-mac.html editing/style/make-text-writing-direction-inline-win.html

Build Bot

Comment 10 2016-12-18 01:51:59 PST

Created attachment 297432 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Wenson Hsieh

Comment 11 2016-12-18 10:04:07 PST

Created attachment 297439 [details] Patch

Wenson Hsieh

Comment 12 2016-12-18 16:38:28 PST

Created attachment 297448 [details] Patch for landing

WebKit Commit Bot

Comment 13 2016-12-18 17:14:50 PST

Comment on attachment 297448 [details] Patch for landing Clearing flags on attachment: 297448 Committed r209976: <http://trac.webkit.org/changeset/209976>

Note You need to log in before you can comment on or make changes to this bug.