Summary: | [CMake] TestWebKitAPIBase links to itself | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | Tools / Tests | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, annulen, bugs-noreply, commit-queue, lforschler, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2016-12-16 19:36:14 PST
I think I hate linkers. This fixes the warnings and it links, but there's got to be a be a better way. I ran into linker errors when I tried anything else, though. In particular, it won't link if I remove TestWebKitAPIBase from test_webkit2_api_LIBRARIES and specify it manually in target_link_libraries for the tests. Created attachment 297403 [details]
Patch
LGTM I don't think linker can take any blame here, it might be cmake but most probably our project structure Comment on attachment 297403 [details] Patch Clearing flags on attachment: 297403 Committed r209991: <http://trac.webkit.org/changeset/209991> All reviewed patches have been landed. Closing bug. |