Bug 165985

Summary: [CMake] TestWebKitAPIBase links to itself
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bugs-noreply, commit-queue, lforschler, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2016-12-16 19:36:14 PST
CMake Warning (dev) at Tools/TestWebKitAPI/CMakeLists.txt:199 (add_library): Policy CMP0038 is not set: Targets may not link directly to themselves. Run "cmake --help-policy CMP0038" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target "TestWebKitAPIBase" links to itself. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at Tools/TestWebKitAPI/CMakeLists.txt:199 (add_library): Policy CMP0038 is not set: Targets may not link directly to themselves. Run "cmake --help-policy CMP0038" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target "TestWebKitAPIBase" links to itself. This warning is for project developers. Use -Wno-dev to suppress it.
Attachments
Patch (1.35 KB, patch)
2016-12-17 06:54 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-12-17 06:53:01 PST
I think I hate linkers. This fixes the warnings and it links, but there's got to be a be a better way. I ran into linker errors when I tried anything else, though. In particular, it won't link if I remove TestWebKitAPIBase from test_webkit2_api_LIBRARIES and specify it manually in target_link_libraries for the tests.
Michael Catanzaro
Comment 2 2016-12-17 06:54:23 PST
Created attachment 297403 [details] Patch
Konstantin Tokarev
Comment 3 2016-12-17 11:16:34 PST
LGTM I don't think linker can take any blame here, it might be cmake but most probably our project structure
WebKit Commit Bot
Comment 4 2016-12-19 11:13:19 PST
Comment on attachment 297403 [details] Patch Clearing flags on attachment: 297403 Committed r209991: <http://trac.webkit.org/changeset/209991>
WebKit Commit Bot
Comment 5 2016-12-19 11:13:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.