Bug 165955

Summary: pairIntHash: remove sharp edge
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: ASSIGNED    
Severity: Normal CC: jfbastien
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

JF Bastien
Reported 2016-12-16 09:54:30 PST
It looks like pairIntHash has a gotcha if it's passed a non-unsigned: it'll be preceded by automatic coercion. That would be a disaster if the value it receives were a uint64_t! AFAICT all uses are fine because all hash functions return unsigned, but some basic template overload would prevent the gotcha.
Attachments
Note You need to log in before you can comment on or make changes to this bug.