Bug 165940

Summary: Add public ICU headers in preparation for https://bugs.webkit.org/show_bug.cgi?id=160629
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, dino, jonlee, mcatanzaro, simon.fraser, thorton, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160629    
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2016-12-15 18:11:54 PST
Add public ICU headers in preparation for https://bugs.webkit.org/show_bug.cgi?id=160629
Attachments
Patch (171.82 KB, patch)
2016-12-15 18:13 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-12-15 18:13:59 PST
Created attachment 297275 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-15 18:16:33 PST
Attachment 297275 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter name "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in fun ction call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 239 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2016-12-15 18:34:29 PST
Comment on attachment 297275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297275&action=review > Source/WTF/icu/unicode/brkiter.h:100 > +class U_COMMON_API BreakIterator : public UObject { Up until this point we have quite deliberately stayed away from ICU’s C++ interface and used the equivalent C interfaces instead. Why not continue to use ubrk.h?
Myles C. Maxfield
Comment 4 2016-12-15 19:37:32 PST
Comment on attachment 297275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297275&action=review >> Source/WTF/icu/unicode/brkiter.h:100 >> +class U_COMMON_API BreakIterator : public UObject { > > Up until this point we have quite deliberately stayed away from ICU’s C++ interface and used the equivalent C interfaces instead. Why not continue to use ubrk.h? We're only using this interface on macOS/iOS where the compiler for ICU is similar to our own. There is currently no way (that I have found) to use the C API with precompiled rules.
Myles C. Maxfield
Comment 5 2016-12-16 10:43:39 PST
(In reply to comment #4) > There is currently no way (that I have found) to use the C API with precompiled rules. I asked the icu-support mailing list if this is correct: https://sourceforge.net/p/icu/mailman/message/35554487/
Myles C. Maxfield
Comment 6 2016-12-16 17:09:29 PST
(In reply to comment #4) > Comment on attachment 297275 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297275&action=review > > >> Source/WTF/icu/unicode/brkiter.h:100 > >> +class U_COMMON_API BreakIterator : public UObject { > > > > Up until this point we have quite deliberately stayed away from ICU’s C++ interface and used the equivalent C interfaces instead. Why not continue to use ubrk.h? > > We're only using this interface on macOS/iOS where the compiler for ICU is > similar to our own. Talking with Mitz about this, neither of us thinks that binary compatibility is a problem for builds which use this code path (aka builds which have the icugenbrk utility)
Myles C. Maxfield
Comment 7 2016-12-20 10:53:12 PST
Comment on attachment 297275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297275&action=review >>>> Source/WTF/icu/unicode/brkiter.h:100 >>>> +class U_COMMON_API BreakIterator : public UObject { >>> >>> Up until this point we have quite deliberately stayed away from ICU’s C++ interface and used the equivalent C interfaces instead. Why not continue to use ubrk.h? >> >> We're only using this interface on macOS/iOS where the compiler for ICU is similar to our own. There is currently no way (that I have found) to use the C API with precompiled rules. > > Talking with Mitz about this, neither of us thinks that binary compatibility is a problem for builds which use this code path (aka builds which have the icugenbrk utility) There hasn't been a response on the mailing list about this. Do you have any more thoughts, Darin?
Myles C. Maxfield
Comment 8 2016-12-20 10:57:45 PST
Dan Bates brought up a good point about this - we have many folders containing ICU headers in WebKit, and it isn't clear what each one is used for (or if they are all necessary). Some of these folders are not kept in sync, and already have different headers in them. Perhaps some are not necessary, but if more than one is required, it's not clear if I should be putting these new headers in all of them or just the one I've put them in for this patch.
Michael Catanzaro
Comment 9 2016-12-21 12:42:30 PST
I'd like to see the ICU headers move to one directory under Source/ThirdParty instead of adding them in WTF. It's slightly odd to have only headers and no implementation under Source/ThirdParty, but these are still third-party sources that need to be tracked separately from our own code.
Myles C. Maxfield
Comment 10 2017-01-14 19:14:15 PST
http://bugs.icu-project.org/trac/ticket/12914 shows that a C API in ICU was accepted to read precompiled rules. Therefore, this patch is no longer necessary.
Daniel Bates
Comment 11 2017-01-14 22:34:33 PST
Comment on attachment 297275 [details] Patch Clearing review flag so that the patch does not show up in the list of pending reviews.
Note You need to log in before you can comment on or make changes to this bug.