Bug 16594

Summary:

Fixes for two bugs in wx graphics code

Product:

WebKit

Reporter:

Kevin Ollivier <kevino>

Component:

WebKit wx

Assignee:

Kevin Ollivier <kevino>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Couple small fixes for wx graphics issues	eric: review+

Kevin Ollivier

Reported 2007-12-23 16:53:31 PST

Just submitting fixes for a couple of bugs I found in the graphics code. One makes getWxBitmap() return the current frame rather than always returning the first frame, and the other stops fillRect from drawing a border. Note that I'm going to be out of town starting tomorrow morning, so I may be a bit slow in replying. I wanted to get these out before I started having so much fun that I forgot about them. :)

Attachments
Couple small fixes for wx graphics issues (1.65 KB, patch) 2007-12-23 16:54 PST, Kevin Ollivier	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kevin Ollivier

Comment 1 2007-12-23 16:54:20 PST

Created attachment 18081 [details] Couple small fixes for wx graphics issues

Eric Seidel (no email)

Comment 2 2007-12-23 17:00:13 PST

Comment on attachment 18081 [details] Couple small fixes for wx graphics issues I think that getWxBitmap should just be replaced by nativeImageForCurrentFrame() and removed instead of being fixed. Otherwise it looks fine.

Eric Seidel (no email)

Comment 3 2007-12-23 17:57:08 PST

Comment on attachment 18081 [details] Couple small fixes for wx graphics issues Looks good. you said you'd get rid of getWxBitmap when you land.

Kevin Ollivier

Comment 4 2007-12-23 18:09:58 PST

landed in r28970 with suggested changes

Note You need to log in before you can comment on or make changes to this bug.