Summary: | Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam | ||||||||||||||
Priority: | P2 | Keywords: | WebExposed | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2016-12-15 10:54:01 PST
Created attachment 297206 [details]
Patch
Comment on attachment 297206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297206&action=review > LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-subclasses-constructors-expected.txt:37 > +PASS KeyboardEvent constructor (argument with non-default values) Wow, this is the only test we have to cover this functionality. Can we please add more tests? Created attachment 297214 [details]
Patch
Created attachment 297216 [details]
Patch
Looks good, but please fix GTK. r=me. Created attachment 297238 [details]
Patch
Created attachment 297241 [details]
Patch
Comment on attachment 297241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297241&action=review > LayoutTests/fast/events/script-tests/init-events.js:110 > +shouldBeUndefined("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').keyCode"); > +shouldBeUndefined("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').charCode"); I would have thought we’d do this instead: shouldBeFalse("'charCode' in xxx"); Why not test that that the property is not even present rather than testing for the weaker condition that the property’s value is undefined? (In reply to comment #8) > Comment on attachment 297241 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297241&action=review > > > LayoutTests/fast/events/script-tests/init-events.js:110 > > +shouldBeUndefined("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').keyCode"); > > +shouldBeUndefined("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').charCode"); > > I would have thought we’d do this instead: > > shouldBeFalse("'charCode' in xxx"); > > Why not test that that the property is not even present rather than testing > for the weaker condition that the property’s value is undefined? Ok, will fix before landing. Created attachment 297258 [details]
Patch
Comment on attachment 297258 [details] Patch Clearing flags on attachment: 297258 Committed r209895: <http://trac.webkit.org/changeset/209895> All reviewed patches have been landed. Closing bug. |