Bug 165892

Summary:

[Cocoa] Implement font-synthesis: small-caps

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, hyatt, jonlee, rniwa, simon.fraser, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
Patch	none
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none
Patch	hyatt: review+, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite	none

Myles C. Maxfield

Reported 2016-12-14 21:46:28 PST

[Cocoa] Implement font-synthesis: small-caps

Attachments
WIP (16.96 KB, patch) 2016-12-14 21:48 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (26.62 KB, patch) 2016-12-14 22:37 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-yosemite (1.33 MB, application/zip) 2016-12-14 23:44 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.24 MB, application/zip) 2016-12-14 23:47 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (1.66 MB, application/zip) 2016-12-14 23:58 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (17.94 MB, application/zip) 2016-12-14 23:59 PST, Build Bot	no flags	Details
Patch (34.52 KB, patch) 2016-12-15 11:15 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (34.47 KB, patch) 2016-12-15 11:18 PST, Myles C. Maxfield	hyatt: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.18 MB, application/zip) 2016-12-15 12:12 PST, Build Bot	no flags	Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2016-12-14 21:48:16 PST

Created attachment 297164 [details] WIP

Myles C. Maxfield

Comment 2 2016-12-14 22:37:19 PST

Created attachment 297169 [details] Patch

Myles C. Maxfield

Comment 3 2016-12-14 22:40:43 PST

Comment on attachment 297169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297169&action=review > Source/WebCore/ChangeLog:8 > + The CSS 3 fonts spec adds a new value to the "font-synthesis" Whoops - it's in CSS Fonts level 4

Build Bot

Comment 4 2016-12-14 23:44:26 PST

Comment on attachment 297169 [details] Patch Attachment 297169 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2726575 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style-font-family.html fast/css3-text/font-synthesis-parse.html

Build Bot

Comment 5 2016-12-14 23:44:31 PST

Created attachment 297173 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-12-14 23:47:20 PST

Comment on attachment 297169 [details] Patch Attachment 297169 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2726576 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css3-text/font-synthesis-parse.html fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-font-family.html fast/css/getComputedStyle/computed-style-without-renderer.html

Build Bot

Comment 7 2016-12-14 23:47:25 PST

Created attachment 297174 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-12-14 23:58:21 PST

Comment on attachment 297169 [details] Patch Attachment 297169 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2726600 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style-font-family.html fast/css3-text/font-synthesis-parse.html

Build Bot

Comment 9 2016-12-14 23:58:26 PST

Created attachment 297176 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 10 2016-12-14 23:59:11 PST

Comment on attachment 297169 [details] Patch Attachment 297169 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2726581 New failing tests: fast/css/getComputedStyle/computed-style-font-family.html fast/css3-text/font-synthesis-parse.html

Build Bot

Comment 11 2016-12-14 23:59:16 PST

Created attachment 297177 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 12 2016-12-15 11:15:40 PST

Created attachment 297203 [details] Patch

Myles C. Maxfield

Comment 13 2016-12-15 11:18:43 PST

Created attachment 297204 [details] Patch

Dave Hyatt

Comment 14 2016-12-15 12:04:25 PST

Comment on attachment 297204 [details] Patch r=me

Build Bot

Comment 15 2016-12-15 12:12:43 PST

Comment on attachment 297204 [details] Patch Attachment 297204 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2730258 New failing tests: http/tests/misc/acid3.html

Build Bot

Comment 16 2016-12-15 12:12:48 PST

Created attachment 297208 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Myles C. Maxfield

Comment 17 2016-12-15 14:13:00 PST

Committed r209875: <http://trac.webkit.org/changeset/209875>

Note You need to log in before you can comment on or make changes to this bug.