Bug 165892

Summary: [Cocoa] Implement font-synthesis: small-caps
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dino, hyatt, jonlee, rniwa, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Archive of layout-test-results from ews100 for mac-yosemite
none
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews117 for mac-yosemite
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch
none
Patch
hyatt: review+, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite none

Description Myles C. Maxfield 2016-12-14 21:46:28 PST
[Cocoa] Implement font-synthesis: small-caps
Comment 1 Myles C. Maxfield 2016-12-14 21:48:16 PST
Created attachment 297164 [details]
WIP
Comment 2 Myles C. Maxfield 2016-12-14 22:37:19 PST
Created attachment 297169 [details]
Patch
Comment 3 Myles C. Maxfield 2016-12-14 22:40:43 PST
Comment on attachment 297169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297169&action=review

> Source/WebCore/ChangeLog:8
> +        The CSS 3 fonts spec adds a new value to the "font-synthesis"

Whoops - it's in CSS Fonts level 4
Comment 4 Build Bot 2016-12-14 23:44:26 PST
Comment on attachment 297169 [details]
Patch

Attachment 297169 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2726575

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css3-text/font-synthesis-parse.html
Comment 5 Build Bot 2016-12-14 23:44:31 PST
Created attachment 297173 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-12-14 23:47:20 PST
Comment on attachment 297169 [details]
Patch

Attachment 297169 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2726576

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css3-text/font-synthesis-parse.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css/getComputedStyle/computed-style-without-renderer.html
Comment 7 Build Bot 2016-12-14 23:47:25 PST
Created attachment 297174 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-12-14 23:58:21 PST
Comment on attachment 297169 [details]
Patch

Attachment 297169 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2726600

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style-font-family.html
fast/css3-text/font-synthesis-parse.html
Comment 9 Build Bot 2016-12-14 23:58:26 PST
Created attachment 297176 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-12-14 23:59:11 PST
Comment on attachment 297169 [details]
Patch

Attachment 297169 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2726581

New failing tests:
fast/css/getComputedStyle/computed-style-font-family.html
fast/css3-text/font-synthesis-parse.html
Comment 11 Build Bot 2016-12-14 23:59:16 PST
Created attachment 297177 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 12 Myles C. Maxfield 2016-12-15 11:15:40 PST
Created attachment 297203 [details]
Patch
Comment 13 Myles C. Maxfield 2016-12-15 11:18:43 PST
Created attachment 297204 [details]
Patch
Comment 14 Dave Hyatt 2016-12-15 12:04:25 PST
Comment on attachment 297204 [details]
Patch

r=me
Comment 15 Build Bot 2016-12-15 12:12:43 PST
Comment on attachment 297204 [details]
Patch

Attachment 297204 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2730258

New failing tests:
http/tests/misc/acid3.html
Comment 16 Build Bot 2016-12-15 12:12:48 PST
Created attachment 297208 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 17 Myles C. Maxfield 2016-12-15 14:13:00 PST
Committed r209875: <http://trac.webkit.org/changeset/209875>