Summary: | [iOS WK2] Don't disable position:fixed when a form element has focus | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, rniwa, simon.fraser, wenson_hsieh | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2016-12-14 21:30:59 PST
Created attachment 297163 [details]
Patch
Attachment 297163 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentView.mm:584: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 297163 [details] Patch Attachment 297163 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2726369 New failing tests: fast/visual-viewport/ios/zoomed-focus-in-fixed.html Created attachment 297171 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 297163 [details] Patch Attachment 297163 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2726793 New failing tests: fast/visual-viewport/ios/zoomed-focus-in-fixed.html Created attachment 297180 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 297163 [details] Patch Attachment 297163 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2726820 New failing tests: fast/visual-viewport/ios/zoomed-focus-in-fixed.html Created attachment 297181 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 297163 [details] Patch Attachment 297163 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2726794 New failing tests: fast/visual-viewport/ios/zoomed-focus-in-fixed.html Created attachment 297182 [details]
Archive of layout-test-results from ews112 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 297163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297163&action=review LGTM other than the test expectations and a typo in the ChangeLog! However, I'm not a WK2 reviewer. > Source/WebKit2/ChangeLog:30 > + (WebKit::WebPage::getAssistedNodeInformation): Don't reset the customtFixedPositionRect around computing element customtFixedPositionRect => customFixedPositionRect > LayoutTests/fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt:2 > +CONSOLE MESSAGE: line 51: rect{"top":22,"right":155.359375,"bottom":43.484375,"left":20,"width":135.359375,"height":21.484375} Are these console messages expected? |