Bug 165762

Summary:

Remove bindings generation support for legacy WebCore::Dictionary

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Bindings

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, buildbot, cdumez, commit-queue, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	sam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none

Darin Adler

Reported 2016-12-12 09:51:41 PST

Remove bindings generation support for legacy WebCore::Dictionary

Attachments
Patch (22.30 KB, patch) 2016-12-12 09:56 PST, Darin Adler	sam: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (949.77 KB, application/zip) 2016-12-12 11:05 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1012.22 KB, application/zip) 2016-12-12 11:10 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (1.54 MB, application/zip) 2016-12-12 11:12 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (12.26 MB, application/zip) 2016-12-12 11:22 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2016-12-12 09:56:42 PST

Created attachment 296931 [details] Patch

Build Bot

Comment 2 2016-12-12 11:05:46 PST

Comment on attachment 296931 [details] Patch Attachment 296931 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2706245 New failing tests: imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl.html imported/w3c/web-platform-tests/webrtc/datachannel-emptystring.html imported/w3c/web-platform-tests/webrtc/no-media-call.html imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html imported/w3c/web-platform-tests/webrtc/promises-call.html

Build Bot

Comment 3 2016-12-12 11:05:50 PST

Created attachment 296934 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-12-12 11:10:04 PST

Comment on attachment 296931 [details] Patch Attachment 296931 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2706251 New failing tests: imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl.html imported/w3c/web-platform-tests/webrtc/datachannel-emptystring.html imported/w3c/web-platform-tests/webrtc/no-media-call.html imported/w3c/web-platform-tests/webrtc/promises-call.html fast/mediastream/RTCPeerConnection-overloaded-operations-params.html imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html fast/mediastream/RTCPeerConnection.html

Build Bot

Comment 5 2016-12-12 11:10:08 PST

Created attachment 296936 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-12-12 11:12:42 PST

Comment on attachment 296931 [details] Patch Attachment 296931 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2706247 New failing tests: imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl.html imported/w3c/web-platform-tests/webrtc/datachannel-emptystring.html imported/w3c/web-platform-tests/webrtc/no-media-call.html imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html imported/w3c/web-platform-tests/webrtc/promises-call.html

Build Bot

Comment 7 2016-12-12 11:12:46 PST

Created attachment 296939 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-12-12 11:22:07 PST

Comment on attachment 296931 [details] Patch Attachment 296931 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2706266 New failing tests: imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl.html imported/w3c/web-platform-tests/webrtc/datachannel-emptystring.html imported/w3c/web-platform-tests/webrtc/no-media-call.html imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html imported/w3c/web-platform-tests/webrtc/promises-call.html

Build Bot

Comment 9 2016-12-12 11:22:12 PST

Created attachment 296941 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Darin Adler

Comment 10 2016-12-12 11:59:22 PST

I have no idea what is going on with all those WebRTC failures. This patch should not have had any effect on that at all!

Darin Adler

Comment 11 2016-12-12 12:00:47 PST

Did the change to MediaDevices.idl somehow break all those WebRTC tests? If so, how could it have?

Darin Adler

Comment 12 2016-12-12 21:18:02 PST

Committed r209752: <http://trac.webkit.org/changeset/209752>

Note You need to log in before you can comment on or make changes to this bug.