Bug 165757

Summary:

REGRESSION (r198990): Cannot edit content inside <details> in wysiwyg editor

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, rniwa

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

148695

Attachments:

Description	Flags
wip	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews113 for mac-yosemite	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
patch	none

Description Antti Koivisto 2016-12-12 07:27:25 PST

<body contenteditable>
<details open>
<p>edit me</p>
</details>

is not editable

Comment 1 Antti Koivisto 2016-12-12 07:32:31 PST

Created attachment 296916 [details]
wip

Comment 2 Build Bot 2016-12-12 08:35:44 PST

Comment on attachment 296916 [details]
wip

Attachment 296916 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2705424

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html

Comment 3 Build Bot 2016-12-12 08:35:47 PST

Created attachment 296918 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 4 Build Bot 2016-12-12 08:39:35 PST

Comment on attachment 296916 [details]
wip

Attachment 296916 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2705432

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html

Comment 5 Build Bot 2016-12-12 08:39:38 PST

Created attachment 296919 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 6 Build Bot 2016-12-12 08:45:04 PST

Comment on attachment 296916 [details]
wip

Attachment 296916 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2705427

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html

Comment 7 Build Bot 2016-12-12 08:45:07 PST

Created attachment 296921 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 8 Build Bot 2016-12-12 08:50:11 PST

Comment on attachment 296916 [details]
wip

Attachment 296916 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2705440

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html

Comment 9 Build Bot 2016-12-12 08:50:15 PST

Created attachment 296922 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

Comment 10 Antti Koivisto 2016-12-13 06:13:40 PST

Created attachment 297010 [details]
patch

Comment 11 Antti Koivisto 2016-12-13 07:57:18 PST

rdar://problem/27991971

Comment 12 WebKit Commit Bot 2016-12-13 08:08:38 PST

Comment on attachment 297010 [details]
patch

Clearing flags on attachment: 297010

Committed r209756: <http://trac.webkit.org/changeset/209756>

Comment 13 WebKit Commit Bot 2016-12-13 08:08:44 PST

All reviewed patches have been landed.  Closing bug.