Bug 165756 – media.webkitPresentationMode may return "inline" in a webkitpresentationmodechanged event handler after entering PiP

• Component: Media
• Status: RESOLVED INVALID

[Antoine Quint]

The test at media/modern-media-controls/pip-support/pip-support-click.html is flaky due to "media.webkitPresentationMode" sometimes returning "inline" within a "webkitpresentationmodechanged" event handler after entering PiP. To reproduce, try to run this command:

Tools/Scripts/run-webkit-tests --release --time-out-ms=5000 --no-sample-on-timeout --exit-after-n-failures=1 --iterations=200 media/modern-media-controls/pip-support/pip-support-click.html

Adding a short timeout works around the problem:

media.addEventListener("webkitpresentationmodechanged", () => {
    setTimeout(() => {
        shouldBeEqualToString("media.webkitPresentationMode", "picture-in-picture");
        container.remove();
        media.remove();
        finishJSTest();
    }, 10);
});

[Antoine Quint]

I now think the test in question was causing the issue as it could end up clicking on the media controls PiP button twice and thus forcing the controls to go from inline to PiP and back to inline.