Summary: | [WebCrypto] Import imported/w3c/web-platform-tests/WebCryptoAPI tests | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||||||||||||||||||||||
Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, cdumez, jiewen_tan, rniwa, webkit-bug-importer, youennf | ||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||
Bug Depends on: | 160880 | ||||||||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||||||||
Attachments: |
|
Description
Jiewen Tan
2016-12-10 02:23:46 PST
Created attachment 300991 [details]
Patch
Comment on attachment 300991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300991&action=review > LayoutTests/TestExpectations:931 > +imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.html [ Slow ] If these are marked as slow in tests-options.json, you should not need to add these lines. Please remove them if that is the case. If they are not added to tests-options.json, it means that these tests are missing a <meta name=timeout content=long>, assuming they take some time. It would be nice to make a PR to WPT repository to add that info. > LayoutTests/TestExpectations:939 > +imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures.worker.html [ Skip ] It is ok I guess. Out of curiosity, why skipping them? Comment on attachment 300991 [details] Patch Attachment 300991 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3028915 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html Created attachment 300995 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 300991 [details] Patch Attachment 300991 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3029086 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html Created attachment 300996 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 300991 [details] Patch Attachment 300991 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3029029 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.html Created attachment 300999 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 300991 [details] Patch Attachment 300991 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3029049 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.html Created attachment 301000 [details]
Archive of layout-test-results from ews116 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 300991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300991&action=review Thanks Youenn for r+ my patch. >> LayoutTests/TestExpectations:931 >> +imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.html [ Slow ] > > If these are marked as slow in tests-options.json, you should not need to add these lines. > Please remove them if that is the case. > > If they are not added to tests-options.json, it means that these tests are missing a <meta name=timeout content=long>, assuming they take some time. > It would be nice to make a PR to WPT repository to add that info. Remove test_successes_RSA-OAEP.html and test_successes_RSASSA-PKCS1-v1_5.html. For successes_RSA-OAEP.worker.html and successes_RSASSA-PKCS1-v1_5.worker.html, it is generated by us. Therefore, keep them. >> LayoutTests/TestExpectations:939 >> +imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures.worker.html [ Skip ] > > It is ok I guess. Out of curiosity, why skipping them? These test cases are a superset of all the test_successes* tests. Therefore, there is no need to run them since we run all the subsets. Created attachment 301059 [details]
Patch for landing
Note that I updated testharness.js last night so your tests may need rebaselining. (In reply to comment #14) > Note that I updated testharness.js last night so your tests may need > rebaselining. Thanks for your information. Comment on attachment 301059 [details] Patch for landing Attachment 301059 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3051409 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html Created attachment 301071 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 301059 [details] Patch for landing Attachment 301059 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3051469 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html Created attachment 301072 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 301059 [details] Patch for landing Attachment 301059 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3051458 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.html Created attachment 301074 [details]
Archive of layout-test-results from ews116 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 301076 [details]
Patch for landing
Comment on attachment 301076 [details] Patch for landing Attachment 301076 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3052531 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker.html Created attachment 301088 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 301104 [details]
Patch for landing
Committed r212124: <http://trac.webkit.org/changeset/212124> |