Bug 165718

Summary: Wasm should support call_indirect
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing keith_miller: commit-queue+

Keith Miller
Reported 2016-12-09 22:08:45 PST
Wasm should support call_indirect
Attachments
Patch (41.77 KB, patch)
2016-12-09 22:21 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (44.32 KB, patch)
2016-12-09 22:26 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (44.28 KB, patch)
2016-12-09 22:38 PST, Keith Miller 		keith_miller: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-09 22:21:53 PST
Created attachment 296778 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-09 22:24:28 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Keith Miller
Comment 3 2016-12-09 22:26:31 PST
Created attachment 296779 [details] Patch for landing
Keith Miller
Comment 4 2016-12-09 22:28:36 PST
rdar://problem/29599153
Keith Miller
Comment 5 2016-12-09 22:38:39 PST
Created attachment 296783 [details] Patch for landing
Keith Miller
Comment 6 2016-12-09 23:13:25 PST
Committed r209652: <http://trac.webkit.org/changeset/209652>
Saam Barati
Comment 7 2016-12-09 23:59:49 PST
Comment on attachment 296783 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=296783&action=review > Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:675 > + jit.call(params[0].gpr()); Why is this correct? params[0] is sometimes the return value of the patchpoint.
Note You need to log in before you can comment on or make changes to this bug.