Bug 165711

Summary: [MediaStream] Protect MediaDevicesRequest during callback
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, dino, jer.noble, thiago.lacerda, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Patch for landing.
sam: review+
Patch for landing. none

Eric Carlson
Reported 2016-12-09 18:44:03 PST
Protect the MediaDevicesRequest object during a call to the completion handler in case the handler is called immediately.
Attachments
Proposed patch. (2.33 MB, patch)
2016-12-09 18:52 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (1.47 KB, patch)
2016-12-10 10:50 PST, Eric Carlson 		sam: review+
DetailsFormatted DiffDiff
Patch for landing. (1.45 KB, patch)
2016-12-11 13:31 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2016-12-09 18:45:22 PST
<rdar://problem/28400468>
Eric Carlson
Comment 2 2016-12-09 18:52:11 PST
Created attachment 296764 [details] Proposed patch.
Eric Carlson
Comment 3 2016-12-10 10:50:12 PST
Created attachment 296808 [details] Patch for landing.
Sam Weinig
Comment 4 2016-12-10 12:22:53 PST
Comment on attachment 296808 [details] Patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=296808&action=review > Source/WebCore/Modules/mediastream/MediaDevicesEnumerationRequest.cpp:91 > + RefPtr<MediaDevicesEnumerationRequest> protectedThis = this; I prefer Ref<MediaDevicesEnumerationRequest> protectedThis(*this) where possible.
Eric Carlson
Comment 5 2016-12-11 13:31:14 PST
Created attachment 296873 [details] Patch for landing.
WebKit Commit Bot
Comment 6 2016-12-11 14:08:37 PST
Comment on attachment 296873 [details] Patch for landing. Clearing flags on attachment: 296873 Committed r209685: <http://trac.webkit.org/changeset/209685>
Note You need to log in before you can comment on or make changes to this bug.