Bug 165709

Summary: Add reflected nonce attribute to HTML Link element IDL
Product: WebKit Reporter: Daniel Bates <dbates>
Component: DOMAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kondapallykalyan
Priority: P2 Keywords: WebExposed
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch and layout test rniwa: review+

Description Daniel Bates 2016-12-09 18:35:54 PST
We should add the reflected nonce attribute to the HTML Link element IDL definition so as to match the HTML standard: <https://html.spec.whatwg.org/multipage/semantics.html#the-link-element> (9 December 2016).
Comment 1 Daniel Bates 2016-12-09 18:37:24 PST
Created attachment 296762 [details]
Patch and layout test
Comment 2 Ryosuke Niwa 2016-12-09 18:43:28 PST
Comment on attachment 296762 [details]
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=296762&action=review

> LayoutTests/fast/dom/nonce-attribute-reflection.html:10
> +var e;

Can we not use a single letter variable like e?
Comment 3 Daniel Bates 2016-12-09 18:50:16 PST
(In reply to comment #2)
> Comment on attachment 296762 [details]
> Patch and layout test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296762&action=review
> 
> > LayoutTests/fast/dom/nonce-attribute-reflection.html:10
> > +var e;
> 
> Can we not use a single letter variable like e?

Will substitute element for e before landing.

For completeness, I chose to use "e" as the name of the global variable so as to focus the attention of the reader on the commands being used to generate the DOM element and set nonce attribute as opposed to the name of the global used solely to string all these commands together so as to make use of shouldBeEqualToString().
Comment 4 Daniel Bates 2016-12-09 18:54:15 PST
Committed r209644: <http://trac.webkit.org/changeset/209644>