Bug 165706

Summary: WebCore::Timer is not compatible with UIProcess
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ahmad.saleem792, andersca, bfulgham, cdumez, commit-queue
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
aestes: review+
Patch for landing.
none
Patch for landing. none

Brent Fulgham
Reported 2016-12-09 17:41:31 PST
WebKit2 UIProcess code should never use WebCore::Timer as it can lead to crashes. This is especially true for applications that make use of WK2 and WK1 at the same time. I tracked down a crash in a WebKit client to the use of WebCore::Timer in NavigationState.mm, which was introduced in https://trac.webkit.org/changeset/204716.
Attachments
Patch (2.58 KB, patch)
2016-12-09 17:44 PST, Brent Fulgham 		aestes: review+
DetailsFormatted DiffDiff
Patch for landing. (2.80 KB, patch)
2016-12-09 17:50 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing. (2.79 KB, patch)
2016-12-09 17:56 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-12-09 17:44:45 PST
Created attachment 296753 [details] Patch
Brent Fulgham
Comment 2 2016-12-09 17:45:45 PST
<rdar://problem/29360564>
Andy Estes
Comment 3 2016-12-09 17:48:23 PST
Comment on attachment 296753 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296753&action=review > Source/WebKit2/UIProcess/Cocoa/NavigationState.h:2 > - * Copyright (C) 2014 Apple Inc. All rights reserved. > + * Copyright (C) 2014-2016 Apple Inc. All rights reserved. Let's also #pragma once-ify this while we're here.
Brent Fulgham
Comment 4 2016-12-09 17:50:43 PST
Created attachment 296754 [details] Patch for landing.
Brent Fulgham
Comment 5 2016-12-09 17:56:10 PST
Created attachment 296755 [details] Patch for landing.
Brent Fulgham
Comment 6 2016-12-09 18:03:21 PST
Comment on attachment 296755 [details] Patch for landing. Turning of CQ+ until tests complete.
Brent Fulgham
Comment 7 2016-12-09 18:59:28 PST
Comment on attachment 296755 [details] Patch for landing. Ready to land.
Chris Dumez
Comment 8 2016-12-09 19:08:49 PST
Thank you for fixing.
WebKit Commit Bot
Comment 9 2016-12-09 19:26:11 PST
Comment on attachment 296755 [details] Patch for landing. Clearing flags on attachment: 296755 Committed r209646: <http://trac.webkit.org/changeset/209646>
Brent Fulgham
Comment 10 2016-12-09 19:38:25 PST
(In reply to comment #8) > Thank you for fixing. Any time! :)
Ahmad Saleem
Comment 11 2024-11-06 19:18:45 PST
This landed - https://github.com/WebKit/WebKit/commit/9d72e5a7d8729a231926b8aba50400652042ff8f Searched via 183302@main, it does not seem to be reverted as well.
Note You need to log in before you can comment on or make changes to this bug.