Bug 165698

Summary: [GTK] Web Inspector: Add NavigationItemCodeCoverage.svg icon
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
joepeck: review+
[Image] Code Coverage Icon
none
Patch none

Nikita Vasilyev
Reported 2016-12-09 16:18:37 PST
NavigationItemCodeCoverage.svg is missing for GTK. https://github.com/WebKit/webkit/blob/master/Source/WebInspectorUI/UserInterface/Images/NavigationItemCodeCoverage.svg
Attachments
Patch (1.58 KB, patch)
2016-12-11 20:10 PST, Nikita Vasilyev 		joepeck: review+
DetailsFormatted DiffDiff
[Image] Code Coverage Icon (2.22 KB, image/png)
2016-12-11 20:12 PST, Nikita Vasilyev 		no flags
Details
Patch (1.58 KB, patch)
2016-12-12 16:48 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2016-12-11 20:10:00 PST
Created attachment 296891 [details] Patch
Nikita Vasilyev
Comment 2 2016-12-11 20:12:55 PST
Created attachment 296892 [details] [Image] Code Coverage Icon
Joseph Pecoraro
Comment 3 2016-12-12 16:42:24 PST
Comment on attachment 296891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296891&action=review > Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCodeCoverage.svg:5 > + <rect stroke="currentColor" width="12" height="12" x=".49998" y="1.0001" fill="none" stroke-width=".99996" stroke-miterlimit="10" stroke-linejoin="bevel" rx="1.2112" ry="1.2111"/> > + <path fill="none" stroke="currentColor" stroke-width="2.4" d="M9 5.5s0-1.5-2.5-1.5C3 4 3 10 6.5 10c2.5 0 2.5-1.5 2.5-1.5"/> Normally Images/gtk has a single space indentation. But I'll leave it up to you if you want to reduce this. Back to cq?
Nikita Vasilyev
Comment 4 2016-12-12 16:48:00 PST
Created attachment 296967 [details] Patch
WebKit Commit Bot
Comment 5 2016-12-12 17:05:49 PST
Comment on attachment 296967 [details] Patch Clearing flags on attachment: 296967 Committed r209748: <http://trac.webkit.org/changeset/209748>
WebKit Commit Bot
Comment 6 2016-12-12 17:05:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.