Bug 165689

Summary:

Remove implementation of legacy Mozilla-based Fullscreen API.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, buildbot, commit-queue, fred.wang, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+
Patch for landing	buildbot: commit-queue-
Archive of layout-test-results from ews115 for mac-yosemite	none
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Patch for landing	none

Jer Noble

Reported 2016-12-09 14:58:28 PST

Remove implementation of very legacy Mozilla-based Fullscreen API.

Attachments
Patch (18.86 KB, patch) 2016-12-09 15:03 PST, Jer Noble	eric.carlson: review+	Details Formatted Diff Diff
Patch for landing (20.05 KB, patch) 2016-12-09 15:35 PST, Jer Noble	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-yosemite (1.66 MB, application/zip) 2016-12-09 17:01 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-yosemite (1.31 MB, application/zip) 2016-12-09 17:17 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.05 MB, application/zip) 2016-12-09 18:06 PST, Build Bot	no flags	Details
Patch for landing (20.74 KB, patch) 2016-12-12 11:12 PST, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2016-12-09 15:00:34 PST

Blink has already removed support for the legacy Mozilla-based Fullscreen API by aliasing it to the W3C version. We should do the same.

Jer Noble

Comment 2 2016-12-09 15:03:26 PST

Created attachment 296712 [details] Patch

Jer Noble

Comment 3 2016-12-09 15:07:22 PST

<rdar://problem/29603053>

Jer Noble

Comment 4 2016-12-09 15:35:49 PST

Created attachment 296723 [details] Patch for landing

Build Bot

Comment 5 2016-12-09 17:01:33 PST

Comment on attachment 296723 [details] Patch for landing Attachment 296723 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2683238 New failing tests: js/dom/dom-static-property-for-in-iteration.html

Build Bot

Comment 6 2016-12-09 17:01:35 PST

Created attachment 296746 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-12-09 17:17:53 PST

Comment on attachment 296723 [details] Patch for landing Attachment 296723 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2683409 New failing tests: js/dom/dom-static-property-for-in-iteration.html

Build Bot

Comment 8 2016-12-09 17:17:55 PST

Created attachment 296747 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-12-09 18:06:12 PST

Comment on attachment 296723 [details] Patch for landing Attachment 296723 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2683699 New failing tests: js/dom/dom-static-property-for-in-iteration.html

Build Bot

Comment 10 2016-12-09 18:06:14 PST

Created attachment 296758 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Jer Noble

Comment 11 2016-12-12 11:12:38 PST

Created attachment 296938 [details] Patch for landing

WebKit Commit Bot

Comment 12 2016-12-12 15:12:46 PST

Comment on attachment 296938 [details] Patch for landing Clearing flags on attachment: 296938 Committed r209730: <http://trac.webkit.org/changeset/209730>

Konstantin Tokarev

Comment 13 2016-12-21 12:23:08 PST

Since Element.ALLOW_KEYBOARD_INPUT is gone now, will it make sense to remove fullscreen/full-screen-keyboard-enabled.html and get rid of bool parameter in supportsFullScreenForElement?

Konstantin Tokarev

Comment 14 2016-12-21 12:23:48 PST

Oops, I've meant ChromeClient::supportsFullScreenForElement (and its callees where applicable)

Jer Noble

Comment 15 2016-12-21 12:46:06 PST

(In reply to comment #14) > Oops, I've meant ChromeClient::supportsFullScreenForElement (and its callees > where applicable) Yes that seems reasonable.

Frédéric Wang (:fredw)

Comment 16 2018-05-23 01:20:35 PDT

Patch landed so I'm closing this bug. I guess the follow-up work (if any) can be done in separate bug.

Note You need to log in before you can comment on or make changes to this bug.