Bug 165686

Summary: [cmake] Include WTF, JSC, and WebCore headers automatically to targets using them
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, gustavo, lforschler, mcatanzaro, mrobinson, ossy, rniwa
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews105 for mac-yosemite-wk2 none

Konstantin Tokarev
Reported 2016-12-09 14:40:32 PST
This change reduces duplication of include path lists between modules, and reduces future need for fixes like r209605 (broken build because of WebCore header suddenly becoming used in WebKit2).
Attachments
Patch (40.56 KB, patch)
2016-12-09 15:02 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (40.65 KB, patch)
2016-12-09 15:16 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (40.96 KB, patch)
2016-12-09 16:23 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (41.04 KB, patch)
2016-12-09 17:27 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (41.04 KB, patch)
2016-12-09 21:10 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (41.67 KB, patch)
2016-12-09 23:53 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (1.10 MB, application/zip)
2016-12-10 01:03 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.03 MB, application/zip)
2016-12-10 01:13 PST, Build Bot 		no flags
Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-12-09 15:02:18 PST
Created attachment 296710 [details] Patch
Konstantin Tokarev
Comment 2 2016-12-09 15:16:29 PST
Created attachment 296715 [details] Patch
Konstantin Tokarev
Comment 3 2016-12-09 16:23:24 PST
Created attachment 296735 [details] Patch
Konstantin Tokarev
Comment 4 2016-12-09 17:27:47 PST
Created attachment 296750 [details] Patch
Konstantin Tokarev
Comment 5 2016-12-09 21:10:58 PST
Created attachment 296775 [details] Patch
Konstantin Tokarev
Comment 6 2016-12-09 23:53:57 PST
Created attachment 296785 [details] Patch
Build Bot
Comment 7 2016-12-10 01:03:50 PST
Comment on attachment 296785 [details] Patch Attachment 296785 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2686444 New failing tests: inspector/codemirror/prettyprinting-css-rules.html
Build Bot
Comment 8 2016-12-10 01:03:53 PST
Created attachment 296790 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 9 2016-12-10 01:13:15 PST
Comment on attachment 296785 [details] Patch Attachment 296785 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2686471 New failing tests: inspector/codemirror/prettyprinting-javascript.html
Build Bot
Comment 10 2016-12-10 01:13:18 PST
Created attachment 296793 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Michael Catanzaro
Comment 11 2016-12-10 08:36:54 PST
Comment on attachment 296785 [details] Patch Great cleanup!
Konstantin Tokarev
Comment 12 2016-12-10 10:16:35 PST
Comment on attachment 296785 [details] Patch Clearing flags on attachment: 296785 Committed r209665: <http://trac.webkit.org/changeset/209665>
Konstantin Tokarev
Comment 13 2016-12-10 10:16:45 PST
All reviewed patches have been landed. Closing bug.
Konstantin Tokarev
Comment 14 2016-12-11 03:12:31 PST
Committed r209680: <http://trac.webkit.org/changeset/209680>
Konstantin Tokarev
Comment 15 2016-12-11 23:14:01 PST
Committed r209700: <http://trac.webkit.org/changeset/209700>
Note You need to log in before you can comment on or make changes to this bug.