Bug 165668 – [Modern Media Controls] Turn modern media controls on by default

• Component: New Bugs
• Status: RESOLVED FIXED

[Antoine Quint]

[Modern Media Controls] Turn modern media controls on by default

[Antoine Quint]

Created attachment 296668 [details]
Not for review, just an EWS run.

[WebKit Commit Bot]

Attachment 296668 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 101 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 296668 [details]
Not for review, just an EWS run.

View in context: https://bugs.webkit.org/attachment.cgi?id=296668&action=review

> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:256
> -    bool m_areModernMediaControlsEnabled { false };
> +    bool m_areModernMediaControlsEnabled { true };

I don't think you need this. The WK2 preferences should set it. Also the DRT and WKTR code is probably doing it as well.

> Source/WebKit2/Shared/WebPreferencesDefinitions.h:317
> +    macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, true, "Modern Media Controls", "Use modern media controls look") \

Use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED

[Build Bot]

Comment on attachment 296668 [details]
Not for review, just an EWS run.

Attachment 296668 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2680177

New failing tests:
accessibility/mac/video-volume-slider-accessibility.html
media/controls/elementOrder.html
media/audio-controls-rendering.html
fast/hidpi/video-controls-in-hidpi.html
media/controls/inline-elements-dropoff-order.html
media/track/track-cue-rendering-horizontal.html
http/tests/media/hls/video-controls-live-stream.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
accessibility/media-emits-object-replacement.html
fullscreen/video-controls-rtl.html
media/controls-without-preload.html
media/controls-after-reload.html
media/media-document-audio-repaint.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/controls-styling.html
accessibility/media-element.html
fast/layers/video-layer.html
media/controls-strict.html
fullscreen/video-controls-drag.html
http/tests/media/hls/video-duration-accessibility.html
media/controls/track-menu.html
media/adopt-node-crash.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/controls/statusDisplay.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html

[Build Bot]

Created attachment 296678 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296668 [details]
Not for review, just an EWS run.

Attachment 296668 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2680190

New failing tests:
accessibility/mac/video-volume-slider-accessibility.html
media/audio-controls-rendering.html
fast/hidpi/video-controls-in-hidpi.html
media/controls/inline-elements-dropoff-order.html
media/track/track-cue-rendering-horizontal.html
http/tests/media/hls/video-controls-live-stream.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
accessibility/media-emits-object-replacement.html
compositing/video/poster.html
fullscreen/video-controls-rtl.html
media/controls-without-preload.html
media/audio-delete-while-slider-thumb-clicked.html
media/controls-after-reload.html
media/media-document-audio-repaint.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/accessibility-closed-captions-has-aria-owns.html
media/controls-styling.html
accessibility/media-element.html
fast/layers/video-layer.html
media/controls-strict.html
fullscreen/video-controls-drag.html
http/tests/media/hls/video-duration-accessibility.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/media-controls-accessibility.html

[Build Bot]

Created attachment 296681 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296668 [details]
Not for review, just an EWS run.

Attachment 296668 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2680188

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/controls-strict.html
media/audio-repaint.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/audio-controls-rendering.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/track/track-cue-rendering-vertical.html
media/controls-without-preload.html
platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html

[Build Bot]

Created attachment 296682 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 296668 [details]
Not for review, just an EWS run.

Attachment 296668 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2680831

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
media/media-document-audio-repaint.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/controls-strict.html
accessibility/mac/video-volume-slider-accessibility.html
accessibility/media-element.html
http/tests/media/hls/video-duration-accessibility.html
accessibility/media-emits-object-replacement.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/audio-controls-rendering.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
fast/hidpi/video-controls-in-hidpi.html
media/controls/inline-elements-dropoff-order.html
media/controls-without-preload.html
fast/layers/video-layer.html
accessibility/mac/video-tag-hit-test.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 296688 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Antoine Quint]

Created attachment 296695 [details]
EWS run, not ready for review.

[WebKit Commit Bot]

Attachment 296695 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 123 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 296695 [details]
EWS run, not ready for review.

Attachment 296695 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2682247

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/track/track-cue-rendering-horizontal.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 296722 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296695 [details]
EWS run, not ready for review.

Attachment 296695 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2682211

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/accessibility-closed-captions-has-aria-owns.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/track/track-cue-rendering-horizontal.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 296724 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296695 [details]
EWS run, not ready for review.

Attachment 296695 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2682168

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html

[Build Bot]

Created attachment 296725 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 296695 [details]
EWS run, not ready for review.

Attachment 296695 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2683109

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
fast/mediastream/MediaStream-video-element-video-tracks-disabled.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 296739 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Antoine Quint]

Created attachment 296897 [details]
EWS run, not for review.

[Build Bot]

Comment on attachment 296897 [details]
EWS run, not for review.

Attachment 296897 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2703486

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 296901 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296897 [details]
EWS run, not for review.

Attachment 296897 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2703570

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 296904 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 296897 [details]
EWS run, not for review.

Attachment 296897 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2703590

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/modern-media-controls/audio/audio-controls-buttons.html
media/modern-media-controls/airplay-support/airplay-support.html
http/tests/media/hls/video-duration-accessibility.html
media/modern-media-controls/pip-support/pip-support-enabled.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
http/tests/media/hls/video-controls-live-stream.html
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html
media/modern-media-controls/placard-support/placard-support-airplay.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/mac/controls-panel-not-clipped-out.html
media/modern-media-controls/placard-support/placard-support-pip.html
media/modern-media-controls/pip-support/pip-support-click.html

[Build Bot]

Created attachment 296905 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296897 [details]
EWS run, not for review.

Attachment 296897 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2704458

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html
http/tests/media/hls/video-duration-accessibility.html
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html
compositing/video/poster.html
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html
media/modern-media-controls/audio/audio-controls-buttons.html
media/modern-media-controls/placard-support/placard-support-airplay.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/mac/controls-panel-not-clipped-out.html
media/modern-media-controls/placard-support/placard-support-pip.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/airplay-support/airplay-support.html
http/tests/media/hls/video-controls-live-stream.html
media/modern-media-controls/pip-support/pip-support-click.html
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html

[Build Bot]

Created attachment 296913 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antoine Quint]

Created attachment 297524 [details]
EWS run, not for review.

[Antoine Quint]

Created attachment 297529 [details]
EWS run, not for review

[Build Bot]

Comment on attachment 297529 [details]
EWS run, not for review

Attachment 297529 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2760363

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/modern-media-controls/airplay-support/airplay-support.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/audio/audio-controls-buttons.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
fast/hidpi/video-controls-in-hidpi.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html
media/track/track-cue-rendering-horizontal.html
http/tests/media/hls/video-controls-live-stream.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html

[Build Bot]

Created attachment 297535 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297529 [details]
EWS run, not for review

Attachment 297529 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2760338

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 297536 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297529 [details]
EWS run, not for review

Attachment 297529 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2760339

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/modern-media-controls/audio/audio-controls-buttons.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/airplay-support/airplay-support.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/mac/controls-panel-not-clipped-out.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 297538 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297529 [details]
EWS run, not for review

Attachment 297529 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2760354

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/icon-button/icon-button-active-state.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/button/button.html

[Build Bot]

Created attachment 297541 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 297589 [details]
EWS run, not for review

[Build Bot]

Comment on attachment 297589 [details]
EWS run, not for review

Attachment 297589 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2765402

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/audio/audio-controls-buttons.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/airplay-autoplay.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 297591 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297589 [details]
EWS run, not for review

Attachment 297589 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2765408

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/audio/audio-controls-buttons.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/mac/controls-panel-not-clipped-out.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 297592 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297589 [details]
EWS run, not for review

Attachment 297589 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2765406

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/accessibility-closed-captions-has-aria-owns.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html
media/modern-media-controls/audio/audio-controls-buttons.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
http/tests/media/hls/video-controls-live-stream.html
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html

[Build Bot]

Created attachment 297593 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297589 [details]
EWS run, not for review

Attachment 297589 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2765436

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/modern-media-controls/button/button.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/icon-button/icon-button-active-state.html

[Build Bot]

Created attachment 297595 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 297600 [details]
EWS run, not for review

[Build Bot]

Comment on attachment 297600 [details]
EWS run, not for review

Attachment 297600 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2765913

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
fast/hidpi/video-controls-in-hidpi.html
compositing/video/poster.html
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html
media/airplay-autoplay.html
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 297608 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297600 [details]
EWS run, not for review

Attachment 297600 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2766023

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
compositing/video/poster.html
media/mac/controls-panel-not-clipped-out.html

[Build Bot]

Created attachment 297611 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297600 [details]
EWS run, not for review

Attachment 297600 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2766027

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
media/accessibility-closed-captions-has-aria-owns.html
compositing/video/poster.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cues-cuechange.html
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html
media/track/track-cue-rendering-horizontal.html
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html

[Build Bot]

Created attachment 297612 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297600 [details]
EWS run, not for review

Attachment 297600 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2766070

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/modern-media-controls/button/button.html
compositing/video/poster.html
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/icon-button/icon-button-active-state.html

[Build Bot]

Created attachment 297615 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298079 [details]
Patch

[Antoine Quint]

Created attachment 298080 [details]
Patch

[Antoine Quint]

Created attachment 298081 [details]
Patch

[Build Bot]

Comment on attachment 298081 [details]
Patch

Attachment 298081 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2837440

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
compositing/video/poster.html
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 298087 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298081 [details]
Patch

Attachment 298081 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2837445

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
compositing/video/poster.html
media/mac/controls-panel-not-clipped-out.html

[Build Bot]

Created attachment 298088 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298081 [details]
Patch

Attachment 298081 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2837444

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
media/accessibility-closed-captions-has-aria-owns.html
compositing/video/poster.html
media/modern-media-controls/audio/audio-controls-buttons.html
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
media/track/track-cues-cuechange.html
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 298089 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298081 [details]
Patch

Attachment 298081 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2837487

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/icon-button/icon-button-active-state.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/button/button.html

[Build Bot]

Created attachment 298092 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298183 [details]
Patch

[Build Bot]

Comment on attachment 298183 [details]
Patch

Attachment 298183 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2842700

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298185 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298183 [details]
Patch

Attachment 298183 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2842746

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298187 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298190 [details]
Patch

[Build Bot]

Comment on attachment 298190 [details]
Patch

Attachment 298190 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2842975

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/audio/audio-controls-buttons.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html
media/track/track-cue-rendering-horizontal.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 298192 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298190 [details]
Patch

Attachment 298190 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2842922

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/accessibility-closed-captions-has-aria-owns.html
fast/hidpi/video-controls-in-hidpi.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/audio/audio-controls-buttons.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
http/tests/media/hls/video-controls-live-stream.html
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html

[Build Bot]

Created attachment 298194 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298190 [details]
Patch

Attachment 298190 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2842976

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
compositing/video/poster.html
media/mac/controls-panel-not-clipped-out.html

[Build Bot]

Created attachment 298195 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298190 [details]
Patch

Attachment 298190 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2842967

New failing tests:
compositing/video/poster.html
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/button/button.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/icon-button/icon-button-active-state.html

[Build Bot]

Created attachment 298196 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298201 [details]
Patch

[Build Bot]

Comment on attachment 298201 [details]
Patch

Attachment 298201 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2843981

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
media/modern-media-controls/audio/audio-controls-buttons.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
fast/hidpi/video-controls-in-hidpi.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html
media/airplay-autoplay.html
media/track/track-cue-rendering-horizontal.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 298207 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298201 [details]
Patch

Attachment 298201 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2843985

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
compositing/video/poster.html
media/mac/controls-panel-not-clipped-out.html

[Build Bot]

Created attachment 298208 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298201 [details]
Patch

Attachment 298201 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2843987

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html
http/tests/media/hls/video-duration-accessibility.html
compositing/video/poster.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html
media/modern-media-controls/audio/audio-controls-buttons.html
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html
media/track/track-cue-rendering-horizontal.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 298209 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298201 [details]
Patch

Attachment 298201 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2844038

New failing tests:
compositing/video/poster.html
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/button/button.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/icon-button/icon-button-active-state.html

[Build Bot]

Created attachment 298212 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298340 [details]
Patch

[Build Bot]

Comment on attachment 298340 [details]
Patch

Attachment 298340 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2858030

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
compositing/video/poster.html
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 298342 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298340 [details]
Patch

Attachment 298340 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2858038

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
compositing/video/poster.html
media/mac/controls-panel-not-clipped-out.html

[Build Bot]

Created attachment 298344 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298340 [details]
Patch

Attachment 298340 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2858040

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
compositing/video/poster.html
media/modern-media-controls/audio/audio-controls-buttons.html
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 298346 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298349 [details]
Patch

[Build Bot]

Comment on attachment 298349 [details]
Patch

Attachment 298349 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2858329

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
compositing/video/poster.html
media/mac/controls-panel-not-clipped-out.html

[Build Bot]

Created attachment 298352 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298349 [details]
Patch

Attachment 298349 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2858332

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
compositing/video/poster.html
media/accessibility-closed-captions-has-aria-owns.html
fast/hidpi/video-controls-in-hidpi.html

[Build Bot]

Created attachment 298353 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298349 [details]
Patch

Attachment 298349 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2858378

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/airplay-autoplay.html
compositing/video/poster.html
media/track/track-cues-cuechange.html
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 298355 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298349 [details]
Patch

Attachment 298349 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2858367

New failing tests:
compositing/video/poster.html
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/button/button.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/icon-button/icon-button-active-state.html

[Build Bot]

Created attachment 298356 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298463 [details]
Patch

[Build Bot]

Comment on attachment 298463 [details]
Patch

Attachment 298463 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2864406

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html

[Build Bot]

Created attachment 298464 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298463 [details]
Patch

Attachment 298463 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2864453

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/airplay-autoplay.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html

[Build Bot]

Created attachment 298466 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298463 [details]
Patch

Attachment 298463 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2864454

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/mac/controls-panel-not-clipped-out.html

[Build Bot]

Created attachment 298468 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298463 [details]
Patch

Attachment 298463 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2864489

New failing tests:
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/button/button.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/icon-button/icon-button-active-state.html

[Build Bot]

Created attachment 298471 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298560 [details]
Patch

[Build Bot]

Comment on attachment 298560 [details]
Patch

Attachment 298560 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2868759

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html

[Build Bot]

Created attachment 298562 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298560 [details]
Patch

Attachment 298560 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2868769

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html

[Build Bot]

Created attachment 298563 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298560 [details]
Patch

Attachment 298560 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2868838

New failing tests:
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/icon-button/icon-button-active-state.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/button/button.html

[Build Bot]

Created attachment 298565 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298560 [details]
Patch

Attachment 298560 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2869143

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html

[Build Bot]

Created attachment 298569 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298571 [details]
Patch

[Build Bot]

Comment on attachment 298571 [details]
Patch

Attachment 298571 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2869680

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html

[Build Bot]

Created attachment 298577 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298571 [details]
Patch

Attachment 298571 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2869702

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html
media/track/track-in-band-style.html

[Build Bot]

Created attachment 298579 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298571 [details]
Patch

Attachment 298571 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2869756

New failing tests:
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/icon-button/icon-button-active-state.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/button/button.html

[Build Bot]

Created attachment 298584 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298571 [details]
Patch

Attachment 298571 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2869894

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html

[Build Bot]

Created attachment 298586 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298587 [details]
Patch

[Build Bot]

Comment on attachment 298587 [details]
Patch

Attachment 298587 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2870270

New failing tests:
media/track/track-in-band-style.html
media/accessibility-closed-captions-has-aria-owns.html
media/track/track-cues-cuechange.html
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 298588 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298587 [details]
Patch

Attachment 298587 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2870318

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html

[Build Bot]

Created attachment 298589 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298587 [details]
Patch

Attachment 298587 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2870297

New failing tests:
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/icon-button/icon-button-active-state.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/button/button.html

[Build Bot]

Created attachment 298591 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298587 [details]
Patch

Attachment 298587 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2870594

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html

[Build Bot]

Created attachment 298599 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298952 [details]
Patch

[Build Bot]

Comment on attachment 298952 [details]
Patch

Attachment 298952 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2898971

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html

[Build Bot]

Created attachment 298954 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298952 [details]
Patch

Attachment 298952 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2898978

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html

[Build Bot]

Created attachment 298955 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298952 [details]
Patch

Attachment 298952 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2898975

New failing tests:
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/button/button.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/icon-button/icon-button-active-state.html

[Build Bot]

Created attachment 298956 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298952 [details]
Patch

Attachment 298952 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2899090

New failing tests:
media/track/track-in-band-style.html
media/accessibility-closed-captions-has-aria-owns.html
media/track/track-cues-cuechange.html
media/track/track-cue-rendering-horizontal.html
fast/hidpi/video-controls-in-hidpi.html

[Build Bot]

Created attachment 298959 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298960 [details]
Patch

[Build Bot]

Comment on attachment 298960 [details]
Patch

Attachment 298960 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2899356

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/airplay-autoplay.html

[Build Bot]

Created attachment 298963 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298960 [details]
Patch

Attachment 298960 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2899366

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html

[Build Bot]

Created attachment 298964 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298960 [details]
Patch

Attachment 298960 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2899374

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html
fast/hidpi/video-controls-in-hidpi.html

[Build Bot]

Created attachment 298965 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298960 [details]
Patch

Attachment 298960 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2899367

New failing tests:
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/icon-button/icon-button-active-state.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/button/button.html

[Build Bot]

Created attachment 298966 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298969 [details]
Patch

[Build Bot]

Comment on attachment 298969 [details]
Patch

Attachment 298969 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2899939

New failing tests:
fast/hidpi/video-controls-in-hidpi.html
media/track/track-cue-rendering-horizontal.html
media/track/track-cues-cuechange.html
media/modern-media-controls/audio/audio-controls-buttons.html

[Build Bot]

Created attachment 298972 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298969 [details]
Patch

Attachment 298969 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2899957

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/accessibility-closed-captions-has-aria-owns.html
media/track/track-cues-cuechange.html
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 298973 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298969 [details]
Patch

Attachment 298969 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2900018

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html

[Build Bot]

Created attachment 298975 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 299031 [details]
Patch

[Build Bot]

Comment on attachment 299031 [details]
Patch

Attachment 299031 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2904136

New failing tests:
media/track/track-in-band-style.html
media/track/track-cues-enter-exit.html

[Build Bot]

Created attachment 299032 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299031 [details]
Patch

Attachment 299031 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2904193

New failing tests:
media/track/track-cues-enter-exit.html

[Build Bot]

Created attachment 299033 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 299036 [details]
Patch

[Antoine Quint]

Created attachment 299050 [details]
Patch

[Dean Jackson]

Comment on attachment 299050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299050&action=review

> Source/WebCore/ChangeLog:15
> +        mode API was avaiable when it might not be, which caused a few tests to fail.

Typo: available

[Build Bot]

Comment on attachment 299050 [details]
Patch

Attachment 299050 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2905413

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html

[Build Bot]

Created attachment 299056 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 299058 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 299058 [details]
Patch for landing

Clearing flags on attachment: 299058

Committed r210834: <http://trac.webkit.org/changeset/210834>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

This introduced 45 timeouts on the GTK+ bot, so rolling it out. See https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r210834%20(20279)/results.html for results.

[Michael Catanzaro]

Committed r210843: <http://trac.webkit.org/changeset/210843>

[Michael Catanzaro]

(This would not be a bad time to look into related preexisting test failures, e.g. bug #163518, bug #163519, bug #163520, bug #163825).

[Ryan Haddad]

Here are links to failures that were seen on macOS WK1 before the rollout:

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r210835%20(2528)/results.html

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20%28Tests%29/builds/10897

[Antoine Quint]

I skipped the media/modern-media-controls tests and landed again in https://trac.webkit.org/changeset/210848.

[Michael Catanzaro]

We're still up about 30 test failures due to this patch. The bot is not exiting early anymore, so I won't roll it out, but it is a bit sad.

[Ryan Haddad]

Reverted r210848 for reason:

This change introduced media-related LayoutTest failures and crashes on macOS.

Committed r210893: <http://trac.webkit.org/changeset/210893>

[Ryan Haddad]

(In reply to comment #189)
> Reverted r210848 for reason:
> 
> This change introduced media-related LayoutTest failures and crashes on
> macOS.
> 
> Committed r210893: <http://trac.webkit.org/changeset/210893>

macOS WK1
https://bugs.webkit.org/show_bug.cgi?id=167166

macOS WK2
https://bugs.webkit.org/show_bug.cgi?id=167177

[Antoine Quint]

Created attachment 299337 [details]
Patch

[Antoine Quint]

Created attachment 299341 [details]
Patch

[Antoine Quint]

Created attachment 299342 [details]
Patch

[Antoine Quint]

Third time's a charm: https://trac.webkit.org/changeset/210959.

[Alexey Proskuryakov]

This cause lots of test flakiness, including crashes: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r210959%20(2591)/media/modern-media-controls/pip-support/pip-support-enabled-crash-log.txt

Probably not yet ready to be enabled in trunk.