Bug 165586

Summary: Move LEB tests to API tests
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Keith Miller
Reported 2016-12-07 20:14:07 PST
Move LEB tests to API tests
Attachments
Patch (19.11 KB, patch)
2016-12-07 20:26 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.06 KB, patch)
2016-12-07 20:53 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.07 KB, patch)
2016-12-08 09:42 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.09 KB, patch)
2016-12-08 09:45 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-07 20:26:03 PST
Created attachment 296474 [details] Patch
Joseph Pecoraro
Comment 2 2016-12-07 20:30:57 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=296474&action=review > Tools/TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:47 > + /* Simple tests that use all the bits in the array */ Update comment style? > Tools/TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:126 > + Extra newline.
Keith Miller
Comment 3 2016-12-07 20:53:20 PST
Created attachment 296479 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-12-07 21:20:09 PST
Comment on attachment 296479 [details] Patch for landing Rejecting attachment 296479 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Kit/Tools/TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/Objects-normal/x86_64/SaturatedArithmeticOperations.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/Objects-normal/x86_64/LEBDecoder.o Tests/WTF/LEBDecoder.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/2648984
Keith Miller
Comment 5 2016-12-08 09:42:46 PST
Created attachment 296522 [details] Patch for landing
Keith Miller
Comment 6 2016-12-08 09:45:23 PST
Created attachment 296523 [details] Patch for landing
WebKit Commit Bot
Comment 7 2016-12-08 10:00:21 PST
Comment on attachment 296523 [details] Patch for landing Clearing flags on attachment: 296523 Committed r209542: <http://trac.webkit.org/changeset/209542>
WebKit Commit Bot
Comment 8 2016-12-08 10:00:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.