Bug 165572

Summary: [WebIDL] WebGLContextAttributes should be a dictionary
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dbates, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews115 for mac-yosemite
none
Archive of layout-test-results from ews107 for mac-yosemite-wk2
none
Archive of layout-test-results from ews100 for mac-yosemite none

Sam Weinig
Reported 2016-12-07 17:22:01 PST
[WebIDL] WebGLContextAttributes should be a dictionary
Attachments
Patch (54.85 KB, patch)
2016-12-07 17:36 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (73.17 KB, patch)
2016-12-07 21:06 PST, Sam Weinig 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-yosemite (1.91 MB, application/zip)
2016-12-07 22:16 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (942.51 KB, application/zip)
2016-12-07 22:17 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews100 for mac-yosemite (1.26 MB, application/zip)
2016-12-07 22:42 PST, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2016-12-07 17:36:51 PST
Created attachment 296452 [details] Patch
Sam Weinig
Comment 2 2016-12-07 21:06:49 PST
Created attachment 296480 [details] Patch
Build Bot
Comment 3 2016-12-07 22:16:16 PST
Comment on attachment 296480 [details] Patch Attachment 296480 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2649108 New failing tests: fast/canvas/webgl/context-creation-attributes.html
Build Bot
Comment 4 2016-12-07 22:16:18 PST
Created attachment 296487 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-12-07 22:17:13 PST
Comment on attachment 296480 [details] Patch Attachment 296480 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2649155 New failing tests: fast/canvas/webgl/context-creation-attributes.html
Build Bot
Comment 6 2016-12-07 22:17:16 PST
Created attachment 296488 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-12-07 22:42:06 PST
Comment on attachment 296480 [details] Patch Attachment 296480 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2649353 New failing tests: fast/canvas/webgl/context-creation-attributes.html
Build Bot
Comment 8 2016-12-07 22:42:09 PST
Created attachment 296495 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Sam Weinig
Comment 9 2016-12-08 11:10:04 PST
Committed r209549: <http://trac.webkit.org/changeset/209549>
Daniel Bates
Comment 10 2016-12-09 10:30:34 PST
(In reply to comment #9) > Committed r209549: <http://trac.webkit.org/changeset/209549> This broke the Make CMake build: [[ [ 78%] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/mac/DOM/DOMHTMLTableSectionElement.mm.o In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit/mac/DOM/DOMHTMLCanvasElement.mm:30: In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/DerivedSources/ForwardingHeaders/WebCore/HTMLCanvasElement.h:1: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/html/HTMLCanvasElement.h:37:10: fatal error: 'WebGLContextAttributes.h' file not found #include "WebGLContextAttributes.h" ]] <https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/10620/steps/compile-webkit/logs/stdio> Committed attempt to fix the build in <http://trac.webkit.org/changeset/209614>
Note You need to log in before you can comment on or make changes to this bug.