| Summary: | [WebCrypto] Migrate some tests from webkitSubtle to subtle | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
| Component: | Tools / Tests | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, jiewen_tan, lforschler | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 160880 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jiewen Tan
2016-12-07 15:02:03 PST
Created attachment 296427 [details]
Patch
Comment on attachment 296427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296427&action=review I think you did a move, when you just meant to copy. r- unless I misunderstood the point of this patch. > LayoutTests/ChangeLog:3 > + [WebCrypto] Replicate some webkitSubtle tests for subtle You say "replicate" in the patch notes, but you appear to be doing a 'svn mv', which gets rid of the old "webkitSubtle" version. Was this intentional? Comment on attachment 296427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296427&action=review >> LayoutTests/ChangeLog:3 >> + [WebCrypto] Replicate some webkitSubtle tests for subtle > > You say "replicate" in the patch notes, but you appear to be doing a 'svn mv', which gets rid of the old "webkitSubtle" version. Was this intentional? Yes. For those two tests, the intention is to test CryptoKey interface instead of SubtleCrypto/WebkitSubtleCrypto. Therefore, it doesn't matter which SubtleCrypto interface is used to generate the key. Comment on attachment 296427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296427&action=review Looks good. Please revise the title as I suggest to make it clearer that you are "moving" some 'webkitSubtle' tests to use the new 'subtle' API. >>> LayoutTests/ChangeLog:3 >>> + [WebCrypto] Replicate some webkitSubtle tests for subtle >> >> You say "replicate" in the patch notes, but you appear to be doing a 'svn mv', which gets rid of the old "webkitSubtle" version. Was this intentional? > > Yes. For those two tests, the intention is to test CryptoKey interface instead of SubtleCrypto/WebkitSubtleCrypto. Therefore, it doesn't matter which SubtleCrypto interface is used to generate the key. I suggest that you change the title to "Migrate some tests from webkitSubtle to subtle" > LayoutTests/platform/ios-simulator-wk1/TestExpectations:1027 > +crypto/subtle/rsa-indexeddb.html Do we know why these tests don't work on the simulator? Does the SDK lack some features we need? We should probably file some Radars if that is the case. Comment on attachment 296427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296427&action=review Thanks Brent for r+ my patch. >>>> LayoutTests/ChangeLog:3 >>>> + [WebCrypto] Replicate some webkitSubtle tests for subtle >>> >>> You say "replicate" in the patch notes, but you appear to be doing a 'svn mv', which gets rid of the old "webkitSubtle" version. Was this intentional? >> >> Yes. For those two tests, the intention is to test CryptoKey interface instead of SubtleCrypto/WebkitSubtleCrypto. Therefore, it doesn't matter which SubtleCrypto interface is used to generate the key. > > I suggest that you change the title to "Migrate some tests from webkitSubtle to subtle" Fixed. >> LayoutTests/platform/ios-simulator-wk1/TestExpectations:1027 >> +crypto/subtle/rsa-indexeddb.html > > Do we know why these tests don't work on the simulator? Does the SDK lack some features we need? We should probably file some Radars if that is the case. I believe it is just indexedDB is not available in iOS WK1. Created attachment 296959 [details]
Patch for landing
Committed r209749: <http://trac.webkit.org/changeset/209749> |