| Summary: | :hover rule causes a single tap to not activate a slotted anchor element | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Derek Gray <dgray90> | ||||||||||||||||||
| Component: | UI Events | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, koivisto, rniwa, simon.fraser, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | Safari 10 | ||||||||||||||||||||
| Hardware: | iPhone / iPad | ||||||||||||||||||||
| OS: | iOS 10 | ||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||
| Bug Blocks: | 148695 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Derek Gray
2016-12-07 14:38:13 PST
Created attachment 296497 [details] Reproduction in comment #0 I can reproduce this on iOS 10 but it’s fixed on the latest WebKit build on iOS. That's good to know. Thanks Ryosuke This was fixed by https://trac.webkit.org/changeset/209065. Let's actually add a test. Created attachment 296976 [details]
Adds a test
Comment on attachment 296976 [details] Adds a test Attachment 296976 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2709142 New failing tests: fast/shadow-dom/click-on-slotted-anchor-with-hover.html Created attachment 296977 [details]
Archive of layout-test-results from ews100 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 296976 [details] Adds a test Attachment 296976 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2709156 New failing tests: fast/shadow-dom/click-on-slotted-anchor-with-hover.html Created attachment 296978 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 296976 [details] Adds a test Attachment 296976 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2709160 New failing tests: fast/shadow-dom/click-on-slotted-anchor-with-hover.html Created attachment 296980 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 296976 [details] Adds a test Attachment 296976 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2709179 New failing tests: fast/shadow-dom/click-on-slotted-anchor-with-hover.html Created attachment 296982 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 296990 [details]
Adds a test and fixes a bug
Comment on attachment 296990 [details] Adds a test and fixes a bug Attachment 296990 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2710680 New failing tests: fast/shadow-dom/click-on-slotted-anchor-with-hover.html Created attachment 296992 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 296990 [details] Adds a test and fixes a bug View in context: https://bugs.webkit.org/attachment.cgi?id=296990&action=review > Source/WebCore/page/ios/FrameIOS.mm:263 > + for (Node* node = hitTestResult.innerNode(); node && node != terminationNode; node = node->parentInComposedTree()) { > + ASSERT(!node->isInShadowTree() || node->containingShadowRoot()->mode() != ShadowRootMode::UserAgent); The assert doesn't look correct. With <details> you can move from normal tree to UA shadow tree. Committed r209780: <http://trac.webkit.org/changeset/209780> |