Bug 165498

Summary: [Modern Media Controls] Instantiate iOS media controls
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2016-12-06 16:17:36 PST
[Modern Media Controls] Instantiate iOS media controls
Attachments
Patch (7.48 KB, patch)
2016-12-06 16:19 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.34 KB, patch)
2016-12-06 16:38 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2016-12-06 16:19:01 PST
Created attachment 296344 [details] Patch
Dean Jackson
Comment 2 2016-12-06 16:25:37 PST
Comment on attachment 296344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296344&action=review > Source/WebCore/ChangeLog:10 > + We add support for the modern media controls runtime flags in RenderThemeIOS so that we inject > + the modern media controls code when that flag is on for iOS. And in order to display iOS controls > + on iOS, we now return the IOSInlineMediaControls class when instantiating media controls on iOS. Just say: Add support for the modern media controls runtime flags in RenderThemeIOS. And when instantiating iOS controls, return an IOSInlineMediaControls class.
Antoine Quint
Comment 3 2016-12-06 16:38:21 PST
Created attachment 296349 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-12-06 19:03:42 PST
Comment on attachment 296349 [details] Patch for landing Clearing flags on attachment: 296349 Committed r209441: <http://trac.webkit.org/changeset/209441>
WebKit Commit Bot
Comment 5 2016-12-06 19:03:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.