Summary: | WebKitTestRunner: Plugins are disabled in new windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebKit2 | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, cmarcelo | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Daniel Bates
2016-12-05 13:23:41 PST
Created attachment 296183 [details]
Patch
Comment on attachment 296183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296183&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:-51 > -WK_EXPORT void WKBundleSetPluginsEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled); Are we sure nobody uses this, or do we need to move it to WKDeprecatedFunctions.cpp? (In reply to comment #2) > Comment on attachment 296183 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296183&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:-51 > > -WK_EXPORT void WKBundleSetPluginsEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled); > > Are we sure nobody uses this, or do we need to move it to > WKDeprecatedFunctions.cpp? As far as I can tell WKBundleSetPluginsEnabled() is only used by WebKitTestRunner. This is consistent with the comment above its declaration "TestRunner only SPIs.", <http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h?rev=209193#L43>. Comment on attachment 296183 [details] Patch Clearing flags on attachment: 296183 Committed r209408: <http://trac.webkit.org/changeset/209408> All reviewed patches have been landed. Closing bug. |