Bug 165410 – WebKitTestRunner: Plugins are disabled in new windows

• Component: WebKit2
• Status: RESOLVED FIXED

[Daniel Bates]

Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens a new window and loads a plugin will fail. We should enable plugins in all windows by default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows. This will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.

[Daniel Bates]

Created attachment 296183 [details]
Patch

[Alex Christensen]

Comment on attachment 296183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296183&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:-51
> -WK_EXPORT void WKBundleSetPluginsEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);

Are we sure nobody uses this, or do we need to move it to WKDeprecatedFunctions.cpp?

[Daniel Bates]

(In reply to comment #2)
> Comment on attachment 296183 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296183&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:-51
> > -WK_EXPORT void WKBundleSetPluginsEnabled(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);
> 
> Are we sure nobody uses this, or do we need to move it to
> WKDeprecatedFunctions.cpp?

As far as I can tell WKBundleSetPluginsEnabled() is only used by WebKitTestRunner. This is consistent with the comment above its declaration "TestRunner only SPIs.", <http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h?rev=209193#L43>.

[Daniel Bates]

Comment on attachment 296183 [details]
Patch

Clearing flags on attachment: 296183

Committed r209408: <http://trac.webkit.org/changeset/209408>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.