Bug 165378

Summary: Add Wasm i64 to i32 conversion.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Keith Miller
Reported 2016-12-05 09:21:35 PST
Add Wasm i32 to i64 conversion.
Attachments
Patch (4.57 KB, patch)
2016-12-05 09:22 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.56 KB, patch)
2016-12-05 10:26 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-05 09:22:20 PST
Created attachment 296145 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-05 09:24:31 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Filip Pizlo
Comment 3 2016-12-05 10:24:22 PST
Comment on attachment 296145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296145&action=review > Source/JavaScriptCore/ChangeLog:3 > + Add Wasm i32 to i64 conversion. Isn't this implementing i64 to i32 conversion?
Filip Pizlo
Comment 4 2016-12-05 10:24:55 PST
Comment on attachment 296145 [details] Patch r=me but reverse the bug title.
Keith Miller
Comment 5 2016-12-05 10:25:34 PST
Comment on attachment 296145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296145&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + Add Wasm i32 to i64 conversion. > > Isn't this implementing i64 to i32 conversion? Yep, I'll fix the title.
Keith Miller
Comment 6 2016-12-05 10:26:42 PST
Created attachment 296157 [details] Patch for landing
WebKit Commit Bot
Comment 7 2016-12-05 11:03:50 PST
Comment on attachment 296157 [details] Patch for landing Clearing flags on attachment: 296157 Committed r209328: <http://trac.webkit.org/changeset/209328>
WebKit Commit Bot
Comment 8 2016-12-05 11:03:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.