Bug 165295

Summary: Remote Inspector: fix weird typo in generated ObjC protocol type initializer implementations
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix none

Blaze Burg
Reported 2016-12-01 20:46:26 PST
This is so weird. We must be using different compiler flags now?
Attachments
Proposed Fix (10.13 KB, patch)
2016-12-01 21:06 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2016-12-01 20:46:36 PST
<rdar://problem/29427778>
Blaze Burg
Comment 2 2016-12-01 21:06:45 PST
Created attachment 295928 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2016-12-01 21:08:52 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Joseph Pecoraro
Comment 4 2016-12-01 21:43:34 PST
Comment on attachment 295928 [details] Proposed Fix Hahah ahh yes. I believe -Wpedantic might catch this.
WebKit Commit Bot
Comment 5 2016-12-01 22:08:53 PST
Comment on attachment 295928 [details] Proposed Fix Clearing flags on attachment: 295928 Committed r209232: <http://trac.webkit.org/changeset/209232>
WebKit Commit Bot
Comment 6 2016-12-01 22:08:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.