Bug 165286

Summary:

SourceCodeKey should use unlinked source code

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	saam: review+

Description Geoffrey Garen 2016-12-01 16:04:47 PST

CodeCacheKey should use unlinked source code

Comment 1 Geoffrey Garen 2016-12-01 16:17:35 PST

Created attachment 295910 [details]
Patch

Comment 2 WebKit Commit Bot 2016-12-01 16:19:05 PST

Attachment 295910 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/parser/UnlinkedSourceCode.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/parser/SourceCode.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Saam Barati 2016-12-01 16:20:57 PST

Comment on attachment 295910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295910&action=review

r=me with some comments

> Source/JavaScriptCore/ChangeLog:3
> +        CodeCacheKey should use unlinked source code

Do you mean SourceCodeKey?

> Source/JavaScriptCore/ChangeLog:15
> +        I plan to deploy UnlinkedSourceCode in more places, to indicate code
> +        that has no absolute location.

Nice

> Source/JavaScriptCore/parser/UnlinkedSourceCode.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

should be 2016

> Source/JavaScriptCore/parser/UnlinkedSourceCode.h:2
> + * Copyright (C) 2008, 2013 Apple Inc. All rights reserved.

should be 2016

> Source/JavaScriptCore/parser/UnlinkedSourceCode.h:15
> + * 1.  Redistributions of source code must retain the above copyright
> + *     notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *     notice, this list of conditions and the following disclaimer in the
> + *     documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Inc. ("Apple") nor the names of
> + *     its contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission.

Looks like the wrong license

Comment 4 Geoffrey Garen 2016-12-01 16:24:38 PST

Committed r209220: <http://trac.webkit.org/changeset/209220>