Bug 165268

Summary: Every WKWebView initialization spends a few milliseconds hitting the disk
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, beidson, mitz, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch beidson: review+

Tim Horton
Reported 2016-12-01 13:13:50 PST
Every WKWebView initialization spends a few milliseconds hitting the disk
Attachments
Patch (16.96 KB, patch)
2016-12-01 13:14 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (19.97 KB, patch)
2016-12-01 13:56 PST, Tim Horton 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-12-01 13:14:17 PST
Created attachment 295883 [details] Patch
Tim Horton
Comment 2 2016-12-01 13:16:31 PST
By my measurement (on iOS), this cuts total time initializing 19 WKWebViews (after the first one) by ~4x (~8ms to ~2ms per view).
Tim Horton
Comment 3 2016-12-01 13:40:09 PST
<rdar://problem/29010113>
Tim Horton
Comment 4 2016-12-01 13:56:59 PST
Created attachment 295891 [details] Patch
Brady Eidson
Comment 5 2016-12-01 14:04:57 PST
Comment on attachment 295891 [details] Patch If I were somebody else, I might say try to keep any calculated path that's a CString as a CString as long as possible. But I guess they all get converted to Strings eventually.
Tim Horton
Comment 6 2016-12-01 14:07:04 PST
(In reply to comment #5) > Comment on attachment 295891 [details] > Patch > > If I were somebody else, I might say try to keep any calculated path that's > a CString as a CString as long as possible. > > But I guess they all get converted to Strings eventually. Yep. Also, stringByResolvingSymlinksInPath is used for similar things all over the place and goes right back to String. I think if we wanted to do that we might want to have a special type just for that purpose.
Tim Horton
Comment 7 2016-12-01 14:31:54 PST
https://trac.webkit.org/changeset/209212
Tim Horton
Comment 8 2016-12-01 14:37:30 PST
Build fix in https://trac.webkit.org/changeset/209214
Note You need to log in before you can comment on or make changes to this bug.