Bug 165252

Summary: Add wasm int to floating point opcodes
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Keith Miller
Reported 2016-12-01 05:28:06 PST
Add wasm int to floating point opcodes
Attachments
Patch (27.78 KB, patch)
2016-12-01 06:34 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (27.87 KB, patch)
2016-12-01 10:21 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (27.86 KB, patch)
2016-12-01 10:50 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.85 KB, patch)
2016-12-01 13:24 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-01 06:34:25 PST
Created attachment 295846 [details] Patch
Keith Miller
Comment 2 2016-12-01 10:21:17 PST
Created attachment 295859 [details] Patch
Geoffrey Garen
Comment 3 2016-12-01 10:43:59 PST
Comment on attachment 295859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295859&action=review r=me > Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:1314 > + AssemblerLabel signedBitSet = m_assembler.jCC(x86Condition(Signed)); It's "sign bit" not "signed bit". > Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:1334 > + AssemblerLabel signedBitSet = m_assembler.jCC(x86Condition(Signed)); Ditto.
Geoffrey Garen
Comment 4 2016-12-01 10:50:00 PST
The clang code for this looks slightly better, and would eliminate the need for a scratch register API difference between platforms: 0000000100000f69 punpckldq 0x1f(%rip), %xmm0 0000000100000f71 subpd 0x27(%rip), %xmm0 0000000100000f79 haddpd %xmm0, %xmm0 I think this is a 128bit "subtract 1 and then double". We can mimic the same with constant operands, since we prefer to avoid introducing globals in the macro assembler.
Keith Miller
Comment 5 2016-12-01 10:50:47 PST
Created attachment 295866 [details] Patch
WebKit Commit Bot
Comment 6 2016-12-01 10:52:45 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Keith Miller
Comment 7 2016-12-01 13:24:25 PST
Created attachment 295885 [details] Patch for landing
WebKit Commit Bot
Comment 8 2016-12-01 14:00:44 PST
Comment on attachment 295885 [details] Patch for landing Clearing flags on attachment: 295885 Committed r209204: <http://trac.webkit.org/changeset/209204>
WebKit Commit Bot
Comment 9 2016-12-01 14:00:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.