Bug 165241

Summary: Stop using WebCore::Dictionary in bindings for Fetch
Product: WebKit Reporter: Darin Adler <darin>
Component: BindingsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch cdumez: review+

Darin Adler
Reported 2016-11-30 21:40:24 PST
Stop using WebCore::Dictionary in bindings for Fetch
Attachments
Patch (18.09 KB, patch)
2016-11-30 22:49 PST, Darin Adler 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-11-30 22:49:15 PST
Created attachment 295822 [details] Patch
Chris Dumez
Comment 2 2016-12-01 09:11:04 PST
Comment on attachment 295822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295822&action=review r=me > Source/WebCore/Modules/fetch/FetchRequest.idl:37 > +dictionary RequestInit { Should be add a FIXME comment to indicate we are missing: HeadersInit headers; BodyInit? body; > Source/WebCore/Modules/fetch/FetchRequest.idl:46 > + any window; The spec has the following comment: // can only be set to null which I think would be useful to have.
Darin Adler
Comment 3 2016-12-01 20:14:49 PST
Comment on attachment 295822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295822&action=review >> Source/WebCore/Modules/fetch/FetchRequest.idl:37 >> +dictionary RequestInit { > > Should be add a FIXME comment to indicate we are missing: > HeadersInit headers; > BodyInit? body; Heh, I had that in an earlier version of this patch. >> Source/WebCore/Modules/fetch/FetchRequest.idl:46 >> + any window; > > The spec has the following comment: > // can only be set to null > > which I think would be useful to have. Also had this, and decided to remove it. I will add it back.
Darin Adler
Comment 4 2016-12-01 21:31:30 PST
Committed r209231: <http://trac.webkit.org/changeset/209231>
Note You need to log in before you can comment on or make changes to this bug.