Bug 165240

Summary: Misc. cleanup in Modules/fetch
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
darin: review+, commit-queue: commit-queue-
[PATCH] For Landing none

Description Joseph Pecoraro 2016-11-30 20:44:38 PST 
Misc. cleanup in Modules/fetch

  - Remove unnecessary includes / forward declarations
  - Cleanup style of some JavaScript to match expected style

Code is very clean! Found these minor details while reading / starting to understand the source.
Comment 1 Joseph Pecoraro 2016-11-30 20:45:15 PST 
Created attachment 295815 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-11-30 22:44:48 PST 
Comment on attachment 295815 [details]
[PATCH] Proposed Fix

Rejecting attachment 295815 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 295815, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
165240.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/2599414
Comment 3 Joseph Pecoraro 2016-12-01 12:46:14 PST 
Created attachment 295878 [details]
[PATCH] For Landing
Comment 4 WebKit Commit Bot 2016-12-01 13:22:29 PST 
Comment on attachment 295878 [details]
[PATCH] For Landing

Clearing flags on attachment: 295878

Committed r209195: <http://trac.webkit.org/changeset/209195>
Comment 5 WebKit Commit Bot 2016-12-01 13:22:32 PST 
All reviewed patches have been landed.  Closing bug.