Summary: | TypeInfo::OutOfLineTypeFlags should be 16 bits in size. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2016-11-30 14:34:51 PST
Created attachment 295774 [details]
proposed patch.
Comment on attachment 295774 [details]
proposed patch.
lgtm
Comment on attachment 295774 [details]
proposed patch.
Do you have a plan for the extra bits?
(In reply to comment #3) > Comment on attachment 295774 [details] > proposed patch. > > Do you have a plan for the extra bits? I have plans to use 1 bit (which would use up the last empty bit in the current 8). Since I was looking at this code and already did the legwork to confirm that we have the extra space, I wanted to just make it clear in the code that we do have that space should we need to add more bits in the future. Thanks for the reviews. Landed in r209162: <http://trac.webkit.org/r209162>. |